Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33
Don't include structmember.h in pythoncapi_compat.h#161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Avoids conflicts due to names without "Py" prefixes.
colesbury commentedNov 7, 2025
This is the first of two issues that I ran into when pulling the latest pythoncapi_compat.h into PyTorch. We ran into name conflicts in downstream packages that had name conflicts because they pulled in both PyTorch headers and things like Thrift. |
vstinner commentedNov 8, 2025
@encukou: Aha, it seems like it's time forPEP 743 – Add Py_OMIT_LEGACY_API to the Python C API :-D I hope that that PEP will beaccepted. |
11cb80f intopython:mainUh oh!
There was an error while loading.Please reload this page.
vstinner commentedNov 8, 2025
Merged, thanks. I like your change, it's a nice way to avoid |
Avoids conflicts due to names without "Py" prefixes.