Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork30
upgrade_pythoncapi: try to preserve newlines when patching#141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
In case we use \n on Windows or \r\n on Linux we don't wantpatching those files change every line due to newlines beingadjusted to the platform defaults.Instead pass 'newline=""' to all open() calls to preservenewlines. And when adding new lines use the first type ofnewline found in the file.The test changes make the patching code reuseable and addsa second test with multiple different newlines in the input.
0a8b2c5 intopython:main 34 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged, thank you! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
In case we use \n on Windows or \r\n on Linux we don't want patching files to change every line due to newlines being adjusted to the platform defaults.
Instead pass 'newline=""' to all open() calls to preserve newlines. And when adding new lines use the first type of newline found in the file.
The test changes make the patching code reuseable and adds a second test with multiple different newlines in the input.