Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix different linkage error with cp313-win#136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
cdce8p wants to merge1 commit intopython:mainfromcdce8p:fix-win

Conversation

cdce8p
Copy link
Contributor

Seems there was one another regression. Our thecp313-win wheel build started to fail after thepythoncapi_compat.h update was merged.We don't test every platform version combination in CI, that's why I missed it initially.

  C:/hostedtoolcache/windows/Python/3.13.1/x64/include/internal/pycore_pystate.h(271): error C2375: '_Py_GetConfig': redefinition; different linkage (diff)  D:/a/mypy/mypy/mypyc/lib-rt/pythoncapi_compat.h(2112): note: see declaration of '_Py_GetConfig' (diff)

Seems like a similar issue to#115 where MSVC requires that the signatures match the upstream ones exactly.

Also updated_Py_fopen_obj even though that didn't fail for us. Probably just because we don't usePy_fopen yet.

@cdce8p
Copy link
ContributorAuthor

/CC@vstinner

@vstinner
Copy link
Member

This issue should be fixed by the changec84545f : can you please try the fix in mypy CI?

@cdce8pcdce8p deleted the fix-win branchJanuary 28, 2025 13:36
@cdce8p
Copy link
ContributorAuthor

This issue should be fixed by the changec84545f : can you please try the fix in mypy CI?

Thanks! My test setup looks fine. Openedpython/mypy#18560 for mypy.
The full CI run is only triggered after merge, but I expect it to be good as well.

vstinner reacted with thumbs up emoji

@vstinner
Copy link
Member

Oh! I misread this pull request. I saw it as an issue and I wrote exactly the same fix :-D Sorry, I could merge your PR directly.

cdce8p reacted with laugh emojicdce8p reacted with heart emoji

@cdce8p
Copy link
ContributorAuthor

can you please try the fix in mypy CI?

It's fixed now.https://github.com/mypyc/mypy_mypyc-wheels/actions/runs/13014956712/job/36301735749

vstinner reacted with hooray emoji

@vstinner
Copy link
Member

Thabks again for your bug report and your fix@cdce8p!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@cdce8p@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp