Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork31
prepare for pypy3.11 release#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -13,7 +13,6 @@ | |||
| import argparse | |||
| import os.path | |||
| import shutil | |||
| import subprocess | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
stray import?
tests/test_pythoncapi_compat.py Outdated
| @@ -62,7 +62,7 @@ def build_ext(): | |||
| display_title("Build test extensions") | |||
| if os.path.exists("build"): | |||
| shutil.rmtree("build") | |||
| cmd = [sys.executable, "setup.py", "build"] | |||
| cmd = [sys.executable, "setup.py", "build", "--debug"] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
although runtests.py runs tests in a subprocess, I could debug my segfaults by running
gdb --args pypy3.11 tests/test_pythoncapi_compat.py -vUsing a debug build makes it easier
Is thewindows 3.6 debug failure on me? I don't think it is related... |
Uh oh!
There was an error while loading.Please reload this page.
0f1d42a intopython:mainUh oh!
There was an error while loading.Please reload this page.
Merged, thanks. Please create a separated PR to add |
Thanks!. I will use |
Ok, I'm also fine with that :-) |
We are working on PyPy3.11. It requires some adjustments here:
PyThreadState_GetInterpreterandPyGC_Collect._PyObject_GetDictPtrreturnsNULLon PyPy. That is probably a bug. In any case, the test should not segfault by dereferencing a NULL pointer so I added a check.