Fix 'redefinition; different linkage' errors with cp313-win#115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 2 commits intopython:mainfromcdce8p:fix-cp313-win

Oct 14, 2024

Merged

Fix 'redefinition; different linkage' errors with cp313-win#115

vstinner merged 2 commits intopython:mainfromcdce8p:fix-cp313-win

Oct 14, 2024

Conversation

Copy link

Contributor

cdce8p commentedOct 14, 2024

After updating mypyc to the latestpythoncapi_compat.h, thecp313-win wheel builds started to fail.

  C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.13.0\tools\include\internal\pycore_unicodeobject.h(262): error C2375: '_PyUnicode_Equal': redefinition; different linkage  D:\a\mypy_mypyc-wheels\mypy_mypyc-wheels\mypy\mypyc\lib-rt\pythoncapi_compat.h(1540): note: see declaration of '_PyUnicode_Equal'  C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.13.0\tools\include\internal\pycore_pyhash.h(24): error C2375: '_Py_HashBytes': redefinition; different linkage  D:\a\mypy_mypyc-wheels\mypy_mypyc-wheels\mypy\mypyc\lib-rt\pythoncapi_compat.h(1567): note: see declaration of '_Py_HashBytes'

https://github.com/mypyc/mypy_mypyc-wheels/actions/runs/11327195039/job/31497783023#step:4:3766

MSVC seems to require that the signature matches the upstream one exactly.

--
The fix here worked for mypyc. Not sure if there is a better one.
/CC@vstinner

--
Refs: