Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Translate wav.po#797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rockleona merged 11 commits intopython:3.12fromMayavi345:translate-wav
Feb 15, 2024
Merged

Translate wav.po#797

rockleona merged 11 commits intopython:3.12fromMayavi345:translate-wav
Feb 15, 2024

Conversation

Mayavi345
Copy link
Contributor

No description provided.

Copy link
Collaborator

@rockleonarockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Review Part 1，晚點繼續接力 Review

抓了簡短的時間 Review 一下，目前翻譯上都沒什麼大問題，
還要花點時間習慣一下這邊的語法編輯習慣喔

Copy link
Collaborator

@rockleonarockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Finish Review

@Mayavi345Mayavi345 deleted the translate-wav branchJanuary 27, 2024 06:55
@mattwang44
Copy link
Collaborator

@Mayavi345 為何要關 PR 呢？

Mayavi345 reacted with confused emoji

@Mayavi345
Copy link
ContributorAuthor

Mayavi345 commentedJan 27, 2024•
edited
Loading

@mattwang44
我以為合併回去了，我就把分支刪掉了。
我恢復，並重新開啟了
謝謝提醒

mattwang44 reacted with thumbs up emoji

@Mayavi345Mayavi345 restored the translate-wav branchJanuary 27, 2024 08:14
@Mayavi345Mayavi345 reopened thisJan 27, 2024
@mattwang44
Copy link
Collaborator

mattwang44 commentedJan 27, 2024•
edited
Loading

@Mayavi345 ok~ 沒關係的，再麻煩你記得把修正的 commits 推上來 🙏🏽
（我看有部分 comment 已經被你 resolve 但沒看到修正？）

Mayavi345 reacted with thumbs up emoji

Mayavi345and others added7 commitsFebruary 3, 2024 16:42
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
@Mayavi345
Copy link
ContributorAuthor

@mattwang44 目前看起來應該是都完成了，謝謝提醒！

@rockleona
Copy link
Collaborator

@Mayavi345 我把沒有修正到的地方都重新打開了，你再看看

如果有任何問題的地方可以問我或是 Matt 都可以喔

Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>
@Mayavi345
Copy link
ContributorAuthor

@rockleona OK 我加入到分支中了，修整完畢

Copy link
Collaborator

@rockleonarockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 感謝@Mayavi345

@rockleonarockleona merged commita7734ef intopython:3.12Feb 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mattwang44mattwang44mattwang44 left review comments

@rockleonarockleonarockleona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Mayavi345@mattwang44@rockleona
[8]ページ先頭
©2009-2025 Movatter.jp