Movatterモバイル変換

Skip to content

python/python-docs-zh-twPublic

NotificationsYou must be signed in to change notification settings
Fork214
Star266

Add a Script to List Translate Progress by File and Show the Assignee#706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

mattwang44 merged 10 commits intopython:3.12fromrockleona:tools/mark_file

Nov 30, 2023

Merged

Add a Script to List Translate Progress by File and Show the Assignee#706

mattwang44 merged 10 commits intopython:3.12fromrockleona:tools/mark_file

Nov 30, 2023

Conversation

rockleona

Copy link

Collaborator

rockleona commentedNov 14, 2023•
edited
Loading

resolve#701

I've add a python code file in.script/mark_file/main.py, and will add a shell script later.

Any suggestion is welcome, and looking forward with any comments :)

rockleona added3 commits

November 14, 2023 22:41

@rockleona

PoC Complete

5182be8

@rockleona

Update f-String Error and Add Shell Script

ed117aa

@rockleona

Add Workfile File

358a00b

@rockleona

rockleona marked this pull request as ready for review

November 15, 2023 10:43

@rockleona

rockleona added this to theScripts for Calculate Translation Progress milestone

mattwang44

mattwang44 reviewed

View reviewed changes

Copy link

Collaborator

mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

其實 potodo 就有提供類似功能（可以嘗試用這個指令potodo -u "https://api.github.com/repos/python/python-docs-zh-tw/issues"），不過重造一個我們想要的版本也沒關係～

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

.github/workflows/mark_file.yml OutdatedShow resolvedHide resolved

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

.scripts/pyproject.toml OutdatedShow resolvedHide resolved

mattwang44

mattwang44 reviewed

View reviewed changes

.scripts/mark_file.sh Outdated

Copy link

Collaborator

mattwang44Nov 15, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

murmur: 雖然是我先開始的，但我覺得這邊用 shell script 爛透了XDD 有時間可以幫忙想一下有沒有更好的方案
例如invoke 或加進 makefile 之類的

Copy link

CollaboratorAuthor

rockleonaNov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

好啊我來研究怎麼新增至 makefile 好了
這個可以讓我到下個 pr 再處理嗎？還是就一步到好XD

Copy link

Collaborator

mattwang44Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

再開其他 PR 處理～

mattwang44

mattwang44 reviewed

View reviewed changes

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

mattwang44

mattwang44 reviewed

View reviewed changes

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

mattwang44

mattwang44 reviewed

View reviewed changes

.scripts/mark_file/main.py OutdatedShow resolvedHide resolved

@rockleona

Copy link

CollaboratorAuthor

rockleona commentedNov 16, 2023

感謝 Matt 的建議，我稍後再來進行修正、回答問題😀

rockleona added4 commits

November 28, 2023 22:37

@rockleona

Fix with Reviewer's Suggestion

212c2d7

@rockleona

Fix GitHub Action Script and pyproject.toml

862fb87

@rockleona

Change to glob for file finding, fix variable assign error

3baa6fc

@rockleona

remove import os

d509e12

@rockleona

Copy link

CollaboratorAuthor

rockleona commentedNov 28, 2023•
edited
Loading

記錄一下目前剩餘的 TODO :

Integrate Shell Script to Makefile
~~Apply regex for Better Pattern Matching When Fetching Issue Title~~

rockleona added2 commits

November 29, 2023 00:18

@rockleona

Add Return Type Hint

0ea058b

@rockleona

Add regex

53986f2

@rockleona

rockleona requested a review frommattwang44

November 28, 2023 17:03

mattwang44

mattwang44 reviewed

View reviewed changes

.github/workflows/summarize_progress.yml OutdatedShow resolvedHide resolved

.scripts/summarize_progress/main.py OutdatedShow resolvedHide resolved

.scripts/summarize_progress/main.py OutdatedShow resolvedHide resolved

.scripts/summarize_progress/main.py OutdatedShow resolvedHide resolved

.github/workflows/summarize_progress.yml OutdatedShow resolvedHide resolved

.scripts/summarize_progress/main.py OutdatedShow resolvedHide resolved

.scripts/summarize_progress/main.py OutdatedShow resolvedHide resolved

.scripts/summarize_progress/main.py OutdatedShow resolvedHide resolved

.scripts/summarize_progress/main.pyShow resolvedHide resolved

.scripts/summarize_progress/main.py OutdatedShow resolvedHide resolved

@rockleona

Update with Reviewer's Suggestion

5f8e511

rockleona

rockleona commented

View reviewed changes

.scripts/summarize_progress/main.py

Comment on lines +77 to +79

		match = re.search("(?P<dirname>[^\s`][a-zA-z-]+)/(?P<filename>[a-zA-Z0-9._-]+(.po)?)", title)
		if not match:
		continue

Copy link

CollaboratorAuthor

rockleonaNov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

這邊 regex 前段我新增了[^\s]`，不然會有 bug

Suggested change

	match=re.search("(?P<dirname>[^\s`][a-zA-z-]+)/(?P<filename>[a-zA-Z0-9._-]+(.po)?)",title)
	ifnotmatch:
	continue
	match=re.search("(?P<dirname>[^\s`][a-zA-z-]+)/(?P<filename>[a-zA-Z0-9._-]+(.po)?)",title)
	ifnotmatch:
	continue

Copy link

CollaboratorAuthor

rockleonaNov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Previous would be like this

@rockleona

rockleona requested a review frommattwang44

November 29, 2023 06:05

mattwang44

mattwang44 approved these changes

View reviewed changes

Copy link

Collaborator

mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ＬＧＴＭ

@mattwang44

mattwang44 merged commit44eb265 intopython:3.12

isabellechiu pushed a commit to isabellechiu/python-docs-zh-tw that referenced this pull request

@rockleona

@isabellechiu

Add a Script to List Translate Progress by File and Show the Assignee (…

04b1286

…python#706)

@rockleona

rockleona mentioned this pull request

fix: Change summarize_progress script to commit at wiki#789

Merged

@rockleona

rockleona mentioned this pull request

chore: change scripts to makefile#821

Draft

beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request

@rockleona

Add a Script to List Translate Progress by File and Show the Assignee (…

dfaf59e

…python#706)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

2 participants

@rockleona

@mattwang44

[8]ページ先頭

©2009-2025 Movatter.jp