Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Translate CSV Module rst:71 to rst:152#582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cschan1828 merged 5 commits intopython:3.12fromrockleona:csv-0806
Aug 15, 2023

Conversation

rockleona
Copy link
Collaborator

@rockleona
Copy link
CollaboratorAuthor

啊....是不是因為我共用前幾天的 PR 的 Branch 造成多個 commit .....@@

@mattwang44
Copy link
Collaborator

啊....是不是因為我共用前幾天的 PR 的 Branch 造成多個 commit .....@@

對歐，可以學一下git rebase 指令怎麼使用，如果不確定怎麼做再請你找我討論 🙏🏽

rockleona reacted with eyes emoji

@mattwang44
Copy link
Collaborator

mattwang44 commentedAug 14, 2023•
edited
Loading

@cschan1828 想請問最近有空來幫忙 review 嗎？

cschan1828 and rockleona reacted with thumbs up emoji

@cschan1828cschan1828 self-requested a reviewAugust 15, 2023 01:23
Copy link
Collaborator

@cschan1828cschan1828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the commit!

有些常見的動詞其實可以考慮直接找中文慣用動詞來用哦，保留原文主要是指專有名詞。

rockleona reacted with heart emoji
@rockleona
Copy link
CollaboratorAuthor

Hi@cschan1828 , thanks for the review!

感謝你的細心，再麻煩幫我看看了，感謝！

cschan1828 reacted with thumbs up emoji

Copy link
Collaborator

@cschan1828cschan1828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

相當不錯了，僅想再釐清一些小細節。

@cschan1828cschan1828enabled auto-merge (squash)August 15, 2023 12:01
Copy link
Collaborator

@cschan1828cschan1828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

很通用的詞語直接用中文即可。

Copy link
Collaborator

@cschan1828cschan1828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Approved.

rockleona reacted with heart emoji
Copy link
Collaborator

@mattwang44mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks guys!

@cschan1828cschan1828 merged commit732575d intopython:3.12Aug 15, 2023
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull requestSep 4, 2024
* Translate rst:71 to rst:152* Update with Reviewer's comment* HOTFIX
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mattwang44mattwang44mattwang44 approved these changes

@cschan1828cschan1828cschan1828 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@rockleona@mattwang44@cschan1828
[8]ページ先頭
©2009-2025 Movatter.jp