Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork215
Translatec-api/refcounting.po#559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@rockleona Please help review this PR when you're available. Thanks! |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
c-api/refcounting.po Outdated
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因 " | ||
| "`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
這句好難喔@@
我修改了一下語句看有沒有比較通順
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因" | |
| "`dst`被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。" | |
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得任何程式碼" | |
| "觸發了`dst`被拆除的副作用 (side-effect) 進而不會相信 `dst` 有指向一個有效物件。" |
想麻煩@rockleona 參與#568 的討論，一起幫忙看看這樣變更會不會有什麼問題 🙏🏽 |
好的，我待會來去看看 |
c-api/refcounting.po Outdated
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因 " | ||
| "`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- code 指的應該是被意外觸發的部分（也就是 side effect）
- 我漏翻 side effect
如果改成這樣呢？
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因" | |
| "`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。" | |
| "這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`，使得因" | |
| "`dst` 被拆除而觸發的任何副作用 (side-effect) 之程式碼不會相信 `dst` 是" | |
| "指向一個有效物件。" |
c-api/refcounting 原文近期有不少變動，最近會再找時間補上這個 PR |
已補 |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
看完一輪之後只能說請收下我的膝蓋吧(X)
太精準了!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
* translate `c-api/refcounting.po`* fix: updated the source strings and their translations* fix(c-api/refcounting): modify based on review comments
Uh oh!
There was an error while loading.Please reload this page.
translate some strings that are newly-added in 3.12 doc
preview