Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Errors correct "//"#54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
AlexWUrobot wants to merge2 commits intopython:3.7fromAlexWUrobot:errorsV3
Closed

Conversation

AlexWUrobot
Copy link

Thank you

@adrianliaw
Copy link
Collaborator

Hi@AlexWUrobot, just in case if you got confused, you don't have to create a new branch and open a new PR just for fixing a previous PR! You can keep pushing onto your add-error branch which constructs#49, could you please re-apply it onadd-error branch and push it there? That would make the discussion flow in a better way, thanks!

@AlexWUrobot
Copy link
Author

AlexWUrobot commentedOct 22, 2018 via email

OKjust replacing the instruction from "git push origin HEAD" to "git pushorigin add-error", right?Then, I don't need to New pull request[image: image.png]

@adrianliaw
Copy link
Collaborator

@AlexWUrobot Thank you so much for doing that for me. I guess you'll have to verify thatgit branch prints outadd-error on your local machine before you dogit push origin HEAD, please let me know if it went wrong even you've verified it.

@AlexWUrobot
Copy link
Author

AlexWUrobot commentedOct 23, 2018 via email

YES, i have verified that git branch prints out add-error and then I do gitpush origin add-errorAdrian Liaw <notifications@github.com> 於 2018年10月23日 週二 上午12:50寫道:
@AlexWUrobot <https://github.com/AlexWUrobot> Thank you so much for doing that for me. I guess you'll have to verify that git branch prints out add-error on your local machine before you do git push origin HEAD, please let me know if it went wrong even you've verified it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#54 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATfFf8OhefFmJo9XxLJt3PvZqd9z348rks5unfdSgaJpZM4XwVPW> .

@adrianliaw
Copy link
Collaborator

@AlexWUrobot That definitely works as everything is explicit, but does it work if you 1. verifygit branch prints outadd-error 2. dogit push origin HEAD?

@AlexWUrobot
Copy link
Author

AlexWUrobot commentedOct 28, 2018 via email

Yes, I verify git branch print out add-error.I did " git push origin add-error " before. Now I do "git push origin HEAD".Thank you[image: image.png]Adrian Liaw <notifications@github.com> 於 2018年10月23日 週二 上午8:34寫道:
@AlexWUrobot <https://github.com/AlexWUrobot> That definitely works as everything is explicit, but does it work if you 1. verify git branch prints out add-error 2. do git push origin HEAD? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#54 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATfFfyej_w-yKzoizll03zlmbIIcrep9ks5unrh0gaJpZM4XwVPW> .

@adrianliaw
Copy link
Collaborator

@AlexWUrobot 不好意思,我想再確認一次你說的意思。你的意思是說如果你執行git push origin HEAD 的話就會正確推到add-error,而不是這裡嗎?如果是的話,我就可以確認我在 README 裡面寫的指示沒有錯。

@AlexWUrobot
Copy link
Author

AlexWUrobot commentedNov 2, 2018 via email

正在當兵 我出去後確認 不好意思Adrian Liaw <notifications@github.com> 於 2018年10月29日 週一 下午3:30 寫道:
@AlexWUrobot <https://github.com/AlexWUrobot> 不好意思,我想再確認一次你說的意思。你的意思是說如果你執行 git push origin HEAD 的話就會正確推到 add-error,而不是這裡嗎?如果是的話,我就可以確認我在 README 裡面寫的指示沒有錯。 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#54 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATfFf4Uz2lbng_CN9wB218sjlwEn900pks5upq6KgaJpZM4XwVPW> .

@mattwang44
Copy link
Collaborator

closed by#76.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@AlexWUrobot@adrianliaw@mattwang44

[8]ページ先頭

©2009-2025 Movatter.jp