Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork215
docs(makefile): add autodocumenting to makefile#239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The GitHub Actions scripts use themake command (which is equivalent tomake all before the change in this PR) for CI. This PR alters the behavior ofmake and thus modifying themake commands tomake all in CI scripts are required.
The CI simply prints the help msg and would be always passed:
https://github.com/python/python-docs-zh-tw/runs/5166355481?check_suite_focus=true
fb64a75 to2211879Compare
Thanks for reminding me. I've fixed that, please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
One little thing that can possibly do is to move the python script from Makefile to a newly-created python script (e.g.scripts/print_makefile_help_msg.py) but we can start this once we think it's necessary.
Uh oh!
There was an error while loading.Please reload this page.
Add autodocumenting to makefile, which works as following,