Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Translatelibrary/queue.po#187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mattwang44 merged 10 commits intopython:3.10fromallen91wu:translate-queue
Sep 29, 2022
Merged

Conversation

allen91wu
Copy link
Collaborator

resolve#181

Preview

image

mattwang44 reacted with rocket emoji
@mattwang44
Copy link
Collaborator

@jordanSu, would you be interested in reviewing this PR?

jordanSu reacted with thumbs up emoji

@jordanSu
Copy link
Contributor

@mattwang44 sorry for late reply, sure let me review this.

mattwang44 reacted with heart emoji

@mattwang44
Copy link
Collaborator

@jordanSu I've sent an invitation for joining this project (in order to set you as a reviewer) a while ago. Remember to confirm it (link).

@jordanSu
Copy link
Contributor

@jordanSu I've sent an invitation for joining this project (in order to set you as a reviewer) a while ago. Remember to confirm it (link).

@mattwang44 sorry for missing the invitation, I found the link has expired, could you kindly send me a new one? Thanks a lot!

@mattwang44
Copy link
Collaborator

@jordanSu just sent!

jordanSu reacted with thumbs up emoji

@mattwang44
Copy link
Collaborator

mattwang44 commentedMar 17, 2022•
edited
Loading

@jordanSu
Is there any chance you can finish reviewing this PR recently? It's fine if you need it to be assigned to another reviewer!

@jordanSu
Copy link
Contributor

@mattwang44 Sorry for late, I might not be able to review it recently, I think it would be better to assign this to another reviewer.
Sorry for making you guys wait🙇

mattwang44 reacted with heart emoji

@mattwang44
Copy link
Collaborator

@jordanSu NP! Thanks for the efforts. Look forward to seeing your contribution again!

jordanSu reacted with heart emoji

@mattwang44mattwang44 removed the request for review fromjordanSuMarch 17, 2022 05:39
@StevenHsuYLStevenHsuYL self-requested a reviewJuly 2, 2022 14:57
Copy link
Contributor

@StevenHsuYLStevenHsuYL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

幫忙 review 一下。
建議僅供參考，大多是閱讀流暢度的小建議，都可以再討論。 😃

ezio-melotti, mattwang44, and allen91wu reacted with thumbs up emoji

#: ../../library/queue.rst:273
msgid ""
"A queue class for use in a multi-processing (rather than multi-threading) "
"context."
msgstr ""
msgstr "用於多工（而非多執行緒）上下文的佇列 class。"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
msgstr "用於多工（而非多執行緒）上下文的佇列 class。"
msgstr "用於多元處理（而非多執行緒）上下文的佇列 class。"

Reference:多元處理 wiki

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

process 一詞目前多翻譯為行程

Suggested change
msgstr "用於多工（而非多執行緒）上下文的佇列 class。"
msgstr "用於多行程處理 (multi-processing)（而非多執行緒）情境 (context) 的佇列 class。"

StevenHsuYL reacted with thumbs up emoji
@mattwang44
Copy link
Collaborator

幫忙 review 一下。 建議僅供參考，大多是閱讀流暢度的小建議，都可以再討論。 😃

感謝 Steven！這個 PR 我會接手處理

StevenHsuYL and allen91wu reacted with thumbs up emoji

@mattwang44mattwang44 self-assigned thisJul 5, 2022
@allen91wu
Copy link
CollaboratorAuthor

Thanks for the review from Steven. I'm just updated the file from the review. Please have a look!

mattwang44 reacted with thumbs up emoji

Copy link
Collaborator

@mattwang44mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

前面 Steven 的 comment 還有一些沒修掉，要再請你檢查一下 🙏🏽

allen91wu reacted with thumbs up emojiallen91wu reacted with eyes emoji
@mattwang44
Copy link
Collaborator

@allen91wu 還差 FIFO 那段 (../../library/queue.rst:37) 的消耗完 要改成消耗
#187 (comment)

allen91wu reacted with eyes emoji

@allen91wu
Copy link
CollaboratorAuthor

@mattwang44 感謝提醒，已經 push 修正過後的版本

mattwang44
mattwang44 previously approved these changesSep 26, 2022
Copy link
Collaborator

@mattwang44mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM
看@StevenHsuYL 有沒有興趣再檢查一下~

allen91wu reacted with hooray emojiallen91wu reacted with rocket emoji
StevenHsuYL
StevenHsuYL previously approved these changesSep 28, 2022
Copy link
Contributor

@StevenHsuYLStevenHsuYL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM (with optional editing later). 👍

Co-authored-by: Steven Hsu <hsuhaochun@gmail.com>
@allen91wu
Copy link
CollaboratorAuthor

@mattwang44@StevenHsuYL
I’m just updated the file from Steven’s suggestion. Please have a look.

@StevenHsuYL
Copy link
Contributor

@mattwang44@StevenHsuYL I’m just updated the file from Steven’s suggestion. Please have a look.

line 360-371 好像重複貼上了，再麻煩修改一下，謝謝！

Co-authored-by: Steven Hsu <hsuhaochun@gmail.com>
Copy link
Collaborator

@mattwang44mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM
Thanks for the great work!

StevenHsuYL and allen91wu reacted with heart emoji
@mattwang44mattwang44 merged commita67c64b intopython:3.10Sep 29, 2022
@allen91wuallen91wu deleted the translate-queue branchSeptember 29, 2022 11:37
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull requestSep 4, 2024
* Translate `library/queue.po`* Translate `library/queue.po`* update file from the review* fix typo* Update library/queue.poCo-authored-by: Steven Hsu <hsuhaochun@gmail.com>* Update library/queue.poCo-authored-by: Steven Hsu <hsuhaochun@gmail.com>* remove redundant partCo-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>Co-authored-by: Steven Hsu <hsuhaochun@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mattwang44mattwang44mattwang44 approved these changes

@StevenHsuYLStevenHsuYLStevenHsuYL left review comments

@josixjosixAwaiting requested review from josix

Assignees

@allen91wuallen91wu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translatelibrary/queue.po
4 participants
@allen91wu@mattwang44@jordanSu@StevenHsuYL
[8]ページ先頭
©2009-2025 Movatter.jp