Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: organize readme#124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
josix merged 6 commits intopython:3.9fromgrimmerk:organize_readme
Oct 21, 2021
Merged

docs: organize readme#124

josix merged 6 commits intopython:3.9fromgrimmerk:organize_readme
Oct 21, 2021

Conversation

grimmerk
Copy link
Contributor

@grimmerkgrimmerk commentedOct 18, 2021•
edited
Loading

@josixjosix self-requested a reviewOctober 18, 2021 15:01
@grimmerkgrimmerk changed the titledocs: add more detailed introduction to readmedocs: organize readmeOct 21, 2021
@grimmerk
Copy link
ContributorAuthor

@josix I've added one more commit. BTW, I mention that "make merge" is periodically executed by GitHub actions. Not sure if this is correct or not.@mattwang44, please correct if I'm wrong.

@grimmerkgrimmerkforce-pushed theorganize_readme branch 3 times, most recently from31ccd37 to5271e8dCompareOctober 21, 2021 05:07
@mattwang44
Copy link
Collaborator

mattwang44 commentedOct 21, 2021•
edited
Loading

"make merge" is periodically executed by GitHub actions

@grimmer0125 Yes, it's correct. We have aworkflow currently runs the command once a day and send a draft PR (likethis one) if there is any modification in CPython Doc. Thanks for mentioning this in the README!


poedit glossary.po

3. 存檔以後，可以輸出文件以確保你的修改沒有 rST 的語法錯誤或警告 ::
3. 存檔以後，執行以下列指令編譯輸出文件，以確保你的修改沒有 rST 的語法錯誤或警告 ::
Copy link
Collaborator

@mattwang44mattwang44Oct 21, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just found out something worth mentioned here (I can open another PR for this so don't worry 😺):

Actually the Makefile expected the translators to do the translation on3.X branch here andmake command would fail if run on a branch that CPython does not have a corresponding one. Idid a hack allowing users to run make command on any branch when I implementing GitHub Action (but forgot to mention it in README).

VERSION=3.9 make

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, I failed to runmake merge and I can add this note later (or anyone else adds it).

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can add this note later (or anyone else adds it).
I think that I may write an incorrect note about this.@mattwang44 could you supply the relevant note (commit) about this?

Copy link
Collaborator

@mattwang44mattwang44Oct 21, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@grimmer0125 Let's cope with this issue in another PR. This PR is good enough to be merged!

@mattwang44
Copy link
Collaborator

Added a commit1200b89 for fixing wrong Telegram invitation link.

Co-authored-by: Josix <wilson8507@gmail.com>
Copy link
Collaborator

@josixjosix left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, Thanks @grimmer0125! This update make the translation workflow more clear a lot.

Copy link
Collaborator

@mattwang44mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@josixjosix merged commit52104be intopython:3.9Oct 21, 2021
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull requestSep 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@josixjosixjosix approved these changes

@mattwang44mattwang44mattwang44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@grimmerk@mattwang44@josix
[8]ページ先頭
©2009-2025 Movatter.jp