Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(action): allow merging cpython on existing branch#110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mattwang44
Copy link
Collaborator

[WHY]

The procedure in current workflow for cpython-syncing is listed as follow:

  1. Cronjob for syncing with cpython triggered daily. A draft PR is sent if any source string has changed.
  2. Developers of this repo should check if the PR is good enough to be merged. Add commits to the same branch if needed (e.g. fixing fuzzy entry and updating translation based on modified source string). Convert it to regular PR if it's ready for review.
  3. Reviewer review and merge this PR.

However, if any commit is added in the step 2. and the cpython-syncing job is triggered before step 3., the commit(s) will be eliminated when forced-pushing since the current workflow do not editing based on existing branch.

[HOW]

Add a stage for reseting to existing branch. If the branch does not exist, this stage would fail but does not block the job.

@mattwang44mattwang44 merged commit2d3ada9 intopython:3.9Sep 13, 2021
@mattwang44mattwang44 deleted the fix/sync-workflow/edit-on-branch branchSeptember 13, 2021 09:25
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull requestSep 4, 2024
…on-branchfix(action): allow merging cpython on existing branch
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@josixjosixjosix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mattwang44@josix

[8]ページ先頭

©2009-2025 Movatter.jp