Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Sync with CPython 3.9#105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
adrianliaw merged 13 commits into3.9fromcron/sync/3.9
Sep 17, 2021
Merged

Sync with CPython 3.9#105

adrianliaw merged 13 commits into3.9fromcron/sync/3.9
Sep 17, 2021

Conversation

github-actions[bot]
Copy link
Contributor

Sync with CPython 3.9

@mattwang44
Copy link
Collaborator

mattwang44 commentedSep 7, 2021
edited
Loading

@adrianliaw I'll keep working on this PR but I need permission to push changes on this branch. Can you grant me the write permission of this repo? or do you prefer me to create a new branch/PR from this branch for syncing?

@mattwang44
Copy link
Collaborator

mattwang44 commentedSep 7, 2021
edited
Loading

Currently, the PR created by the github action does not trigger another workflow (e.g. CI pipeline). One of the workaround is simply close and reopen the PR.
See#107 for details.

It's solved by#108

@mattwang44
Copy link
Collaborator

mattwang44 commentedSep 10, 2021
edited
Loading

@adrianliaw I believe this PR is safe to be merged now since

@pydoc-zh-twpydoc-zh-twbotforce-pushed thecron/sync/3.9 branch 2 times, most recently fromecf161c to97845e0CompareSeptember 12, 2021 00:14
@StevenHsuYL
Copy link
Contributor

The copyright.po had been handled on#93 and merged today.
The sphinx.po had been handled on#99 (not merged yet), and I found that the version tags in your sphinx commit seem not synced with the cpython. May need further review.

@mattwang44
Copy link
Collaborator

@StevenHsuYL Would you please point out which line is not synced?

@StevenHsuYL
Copy link
Contributor

StevenHsuYL commentedSep 16, 2021
edited
Loading

In your sphinx.po file, below msgstr...
"Python 3.10 (in development)"
"Python 3.9 (pre-release)"
"Python 3.8 (stable)"
"Python 3.7 (stable)"
They're not synced with the official doc page (https://docs.python.org/zh-tw/3.9/).

By the way, I found that this section (version tags) is not "translatable" by checking doc homepages in all other languages.
(https://docs.python.org/ja/3.9/)

@mattwang44
Copy link
Collaborator

mattwang44 commentedSep 16, 2021
edited
Loading

@StevenHsuYL
These version tags are translatable as other source strings and they're synced withpython/cpython on the3.9 branch, but the sidebar on docs.python.org are overwritten when building the docs (see the source code inpython/docsbuild-scripts). That's why we cannot find the translated version tags.

StevenHsuYL reacted with thumbs up emoji

@StevenHsuYL
Copy link
Contributor

@mattwang44 Thanks or reply!
I also found out that the version statuses in the sidebar were definedhere in docbuild-scripts.
Should our sphinx.po file sync with these definitions as well?

But as you said, it would always be overwritten, so maybe this part is not very important in our translation project... 🙄

@mattwang44
Copy link
Collaborator

@mattwang44 Thanks or reply!
I also found out that the version statuses in the sidebar were definedhere in docbuild-scripts.
Should our sphinx.po file sync with these definitions as well?

But as you said, it would always be overwritten, so maybe this part is not very important in our translation project... 🙄

I think the current version is fine and we can just leave it 👍🏽.

@adrianliawadrianliaw merged commit3a35894 into3.9Sep 17, 2021
@mattwang44mattwang44 deleted the cron/sync/3.9 branchSeptember 17, 2021 05:30
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull requestSep 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@adrianliawadrianliawAwaiting requested review from adrianliaw

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mattwang44@StevenHsuYL@adrianliaw

[8]ページ先頭

©2009-2025 Movatter.jp