Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updatepython-docs-theme to work with Sphinx 5 & 6#99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JulienPalard merged 9 commits intopython:mainfromAA-Turner:sphinx-6
Apr 13, 2023

Conversation

@AA-Turner
Copy link
Member

Updated remaining jQuery scripts to standard JavaScript, and a few fixes for CSS changes.

A

@AA-Turner
Copy link
MemberAuthor

Turns out this is required for Sphinx 5...python/cpython#99381

A

@AA-TurnerAA-Turner changed the titleUpdate for Sphinx 6Update for Sphinx 5 and 6Nov 11, 2022
Copy link
Member

@pradyunsgpradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Member

@ezio-melottiezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In addition to the inline comments, I have two generic comments:

  • The use of semicolons at the end of the line seems inconsistent. Unless there is a specific reason to keep them, I would just remove them all.
  • I would avoid the use ofif (...) return; orif (...) break; or evenif (...) some_functions(). The expression after the condition should go on a new line, and it should be surrounded by{ }, e.g.:
    if(...){   ...}

Fun fact: I originally implemented both the collapsible sidebar (~12 years ago inpython/cpython#47393) and the copybutton (~11 years ago inpython/cpython@59dba38) and since then they have traveled around a number of dirs and repos. It's nice to see that in the meanwhile things got standardized and JS evolved to the point that JQuery is no longer needed.

hugovk and m-aciek reacted with hooray emoji
@hugovk
Copy link
Member

Is this ready to merge?

@hugovk
Copy link
Member

Rebased onmain to build RTD preview:

And there's an error in the console:

sidebar.js:34 Uncaught TypeError: Cannot read properties of null (reading 'querySelector')    at HTMLDocument.initialiseSidebar (sidebar.js:34:38)

From the last line of:

constbodyWrapper=document.getElementsByClassName("bodywrapper")[0]constsidebar=document.getElementsByClassName("sphinxsidebar")[0]constsidebarWrapper=document.getElementsByClassName('sphinxsidebarwrapper')[0]constsidebarButton=document.getElementById("sidebarbutton")constsidebarArrow=sidebarButton.querySelector('span')

@m-aciekm-aciek mentioned this pull requestMar 13, 2023
@AA-Turner
Copy link
MemberAuthor

Updated the JavaScript, the previous version was attempting to access an element that had yet to be created. Thank you for the review!

A

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Working fine now, thanks!

@AA-TurnerAA-Turner requested review fromJulienPalard andezio-melotti and removed request forJulienPalardApril 11, 2023 20:27
@AA-TurnerAA-Turner changed the titleUpdate for Sphinx 5 and 6Updatepython-docs-theme to work with Sphinx 5 & 6Apr 12, 2023
@JulienPalardJulienPalard merged commit32115c4 intopython:mainApr 13, 2023
@JulienPalard
Copy link
Member

I just builthttps://docs.python.org/3.12/ after merging this PR.

AA-Turner and hugovk reacted with hooray emoji

@AA-Turner
Copy link
MemberAuthor

I just builtdocs.python.org/3.12 after merging this PR.

Working for me in Firefox 112 on Windows! If you have time over the next few weeks, please would we be able to make a2023.4 release, to unblockpython/cpython#99381?

A

@JulienPalard
Copy link
Member

JulienPalard commentedApr 17, 2023
edited
Loading

Releasing:#126

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@pradyunsgpradyunsgpradyunsg approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melotti

@JulienPalardJulienPalardAwaiting requested review from JulienPalard

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AA-Turner@hugovk@JulienPalard@pradyunsg@ezio-melotti

[8]ページ先頭

©2009-2026 Movatter.jp