Fix mobile nav obstructing content#96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pradyunsg merged 1 commit intopython:mainfromphilg314:nav-margin

Feb 13, 2023

Merged

Fix mobile nav obstructing content#96

pradyunsg merged 1 commit intopython:mainfromphilg314:nav-margin

Feb 13, 2023

Conversation

Copy link

Contributor

philg314 commentedAug 8, 2022

Instead of adding the height of.mobile-nav at the top of.document it is now added at the top ofbody.

Closes#95

Fix mobile nav obstructing content

a51bc0a

hugovk force-pushed thenav-margin branch frome005a18 toa51bc0aCompare

February 13, 2023 11:12

Copy link

Member

hugovk commentedFeb 13, 2023

(Rebased onmain to retrigger the CI and create an RTD build preview:https://python-docs-theme-previews--96.org.readthedocs.build/en/96/)

hugovk approved these changes

Feb 13, 2023

View reviewed changes

Copy link

Member

hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Testing locally with the banner enabled on the3.8 branch:

diff --git a/Doc/tools/templates/layout.html b/Doc/tools/templates/layout.htmlindex 98ccf42248..0151a00593 100644--- a/Doc/tools/templates/layout.html+++ b/Doc/tools/templates/layout.html@@ -1,13 +1,11 @@ {% extends "!layout.html" %}  {% block header %}-{%- if outdated %} <div>     {% trans %}This document is for an old version of Python that is no longer supported.     You should upgrade, and read the {% endtrans %}     <a href="/3/{{ pagename }}{{ file_suffix }}">{% trans %} Python documentation for the current stable release{% endtrans %}</a>. </div>-{%- endif %} {% endblock %}  {% block rootrellink %}