This PR needs a review, it looks interesting. (Sadly my front-end skill don't allow me to understand it.)

@pradyunsg would you have time for a review? (I admit I entirely forgot I made this PR...)

A

@JulienPalard can we build and publish a test version of CPython's docs with this PR? That might assuage your concerns over the JS.

A

@JulienPalard can we build and publish a test version of CPython's docs with this PR? That might assuage your concerns over the JS.

Yes but it will be overwritten by the daily build so I doubt it's a good idea. However a build is available in the "checks" tab as a build artifact, so we can test locally. It is done using the same script as in production so it should be similar.

But it builds a 3.9 with a Sphinx 2.4.4, which is probably not very interesting :D

I'll try to find the time to do a full build locally, I mean whith multiple Sphinx versions used by the different python versions, to see if there's any compatibility issue, it's easy to do usingdocsbuild-script and it's--theme argument, if you want to try it, an example invocation is provided in docsbuild's README.

@JulienPalard inspired by a comment from Cam I have taken out all JS changes, which are only strictly necessary for Sphinx 6.python-docs-theme actually works as-is on Sphinx 5.0.1 and newer, so this PR now just updatestests.yml.

A

Let's merge, this only updates the GitHub Actions workflow file and importantly allows testing feature branches (I want to test some changes before creating a PR), and has three approvals.

Thanks!