Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork66
Add a configuration for license URL.#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Would make sense to have at least have a fallback to the previous behavior if the theme variables are undefined, as was implemented on#67 per my suggestion there, for backward compatibility and to follow the approach there for the copyright link? Other than that, this is a pretty important change, since the link is broken at present. |
The current "fallback" is just not to display the link, I'm not sure we can do better here. Do you have something better in mind? |
CAM-Gerlach commentedDec 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah, sorry for the delay—what I was suggesting you could do something like was done for the copyright URL right above it, fall back to a corrected version of the previous behavior, i.e. the hardcoded path, unless the existing behavior was always broken and never actually functioned as intended (which may be the case, I didn't trawl through the full commit history to check). |
I'm puzzeled: the current implementation works on some pages but not all. It works at least on: |
Hum, no, I'm just not awaken yet, on those page, it work like on many other pages: it redirects on the "Current page". In all cases it's a |
I modified my PR a bit to avoid changing the msgid for translators. |
closes#89
You're right@merwok, the assignment were reversed (and useless so they were not introducing a bug).
I made the link to the license configurable, so we could add
license_url
cpython side to point to it (near it'sissues_url
inDoc/config.py
)