Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use default pygments theme#68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JulienPalard merged 1 commit intopython:masterfromBlendify:patch-1
May 1, 2021
Merged

Conversation

Blendify
Copy link
Contributor

The default theme looks a lot better than the default theme with the green background.

The default theme looks a lot better than the default theme with the green background.
@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Blendify

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@JulienPalard
Copy link
Member

Before :
Screenshot_2021-03-23 http client — HTTP protocol client — Python 3 9 2 documentation(1)
After :
Screenshot_2021-03-23 http client — HTTP protocol client — Python 3 9 2 documentation

@pradyunsg
Copy link
Member

Is anything blocking this merging?

@JulienPalard
Copy link
Member

I think it's subjective, I fear someone will open a PR to use Sphinx instead of defaut telling it looks better and we enter an infinite loop.

So what's blocking this PR is the lack of concensus. Maybe open an poll on discuss.python.org or twitter, and if the concensus is clear, we could merge this.

  • I see one good point: redish literals do pop out cleaner.
  • I see one bad point: light grey output is less readable.

@pablogsal
Copy link
Member

I can apport a non-subjective point: I am very colorblind and I can read much better the second one

pradyunsg reacted with thumbs up emoji

@JulienPalard
Copy link
Member

I can apport a non-subjective point: I am very colorblind and I can read much better the second one

Thanks for your feedback!

@JulienPalardJulienPalard merged commit5586486 intopython:masterMay 1, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@Blendify@the-knights-who-say-ni@JulienPalard@pradyunsg@pablogsal

[8]ページ先頭

©2009-2025 Movatter.jp