@CAM-Gerlach Thanks again, that was super helpful, and I learned more about Sphinx along the way. I committed your second suggestion and will also submit a PR to add the license URL to the dictionaryhtml_theme_options inside the devguide'sconf.py.

You're welcome, I'm glad! I'm no expert at Sphinx theming either; I know just enough to be dangerous 😆 Looks like its up to@Mariatta for the final review?

Could you explain how to use it? because with my workflow, it doesn't work.

git clone https://github.com/python/devguidecd devguidemake venv./venv/bin/pip install -U pip./venv/bin/pip uninstall python-docs-theme./venv/bin/pip install git+https://github.com/jablonskidev/python-docs-theme.git@patch-1

patch with this diff

diff --git a/conf.py b/conf.pyindex 4071095..f20b61f 100644--- a/conf.py+++ b/conf.py@@ -95,6 +95,7 @@ pygments_style = 'sphinx' # Use the upstream python-docs-theme html_theme = 'python_docs_theme' html_theme_options = {+    'copyright_url': 'https://www.demo.org',     'collapsiblesidebar': True,     'issues_url': 'https://github.com/python/devguide/issues/new', }

> make html./venv/bin/sphinx-build -b html -d _build/doctrees   . _build/htmlRunning Sphinx v3.5.4making output directory... doneloading intersphinx inventory from https://docs.python.org/3/objects.inv...building [mo]: targets for 0 po files that are out of datebuilding [html]: targets for 35 source files that are out of dateupdating environment: [new config] 35 added, 0 changed, 0 removedreading sources... [100%] triaginglooking for now-outdated files... none foundpickling environment... donechecking consistency... donepreparing documents... WARNING: unsupported theme option 'copyright_url' givendonewriting output... [100%] triaginggenerating indices... genindex donewriting additional pages... search donecopying images... [100%] images/python-cyclic-gc-5-new-page.pngcopying static files... donecopying extra files... donedumping search index in English (code: en)... donedumping object inventory... donebuild succeeded, 1 warning.The HTML pages are in _build/html.Build finished. The HTML pages are in _build/html.

As you can see, I have gotWARNING: unsupported theme option 'copyright_url' given

Any idea?

Thank you

Thanks@matrixise . This PR neglected to add

copyright_url =

intheme.conf as mentioned in my review comment above, and it seems I didn't notice the omission earlier, sorry. That's why you're seeing the warning. However, it may still have worked, I'm not certain—I presume you actually checked the build output and the link was not correct?

That's why you're seeing the warning. However, it may still have worked, I'm not certain—I presume you actually checked the build output and the link was not correct?

In fact, without this parameter, the build of the devguide or another project using this PR would generate a Warning with the undefinedcopyright_url option

In this case, thecopyright_url must be defined into thetheme.conf file.

@jablonskidev Could you update your PR with thecopyright_url option?

Thank you

@matrixise@CAM-Gerlach Thanks for your feedback! I addedcopyright_url = totheme.conf. If there's anything else I can do to improve this and help move it forward, then please let me know.

Thanks@jablonskidev I am going to check in few minutes.

@Mariatta What do you think about this PR, for me, it's fine, and we can merge it.

@JulienPalard Just to be sure. For you, is there an issue with this PR and the "copyright" link in the existing documentations? Thanks