Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+#57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 1 commit intopython:masterfromzmwangx:codebgcolor-codetextcolor
Dec 19, 2020

Conversation

zmwangx
Copy link
Contributor

Sphinx 3.1.0+ dropped the customcodebgcolor andcodetextcolor from the classic theme (see commitsphinx-doc/sphinx@b345acc), leaving pre elements uncolored.

Without the fix:

Screen Shot 2020-10-10 at 11 14 05 AM

Should be:

Screen Shot 2020-10-10 at 11 15 19 AM

Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classictheme[1], leaving pre elements uncolored.[1]sphinx-doc/sphinx@b345acc
zmwangx added a commit to zmwangx/dim that referenced this pull requestOct 10, 2020
@zmwangx
Copy link
ContributorAuthor

Wait, was this change intentional? Just noticed thatPython 3.10 docs, rendered with Sphinx 3.2.1, features background color-less code blocks.

In any case I certainly prefer the old style.

@JulienPalard
Copy link
Member

JulienPalard commentedOct 10, 2020•
edited
Loading

Looks related tosphinx-doc/sphinx#7720 /sphinx-doc/sphinx#7721

@zmwangx
Copy link
ContributorAuthor

@corona10
Copy link
Member

@pablogsalpablogsal merged commite77bd1a intopython:masterDec 19, 2020
@pablogsal
Copy link
Member

pablogsal commentedDec 19, 2020•
edited
Loading

@Mariatta Do you happen to know who has privileges to publish a new version to pypi? We need a new version to restore the colourized backgrounds.

@Mariatta
Copy link
Member

I can publish this later this evening.

pablogsal and JulienPalard reacted with heart emoji

@zmwangxzmwangx deleted the codebgcolor-codetextcolor branchDecember 21, 2020 05:27
@Mariatta
Copy link
Member

We've released v 2020.12
On PyPI:https://pypi.org/project/python-docs-theme/2020.12/
Changeloghttps://github.com/python/python-docs-theme/releases/tag/v2020.12

hugovk, pablogsal, and zmwangx reacted with rocket emoji

@pablogsal
Copy link
Member

Thanks a lot@Mariatta!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalpablogsal approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@zmwangx@JulienPalard@corona10@pablogsal@Mariatta@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp