Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork74
Add support for Python 3.15#282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AA-Turner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If it were me, I'd probably duplicate the jobs -- one for released & one for in-development.
| include: | ||
| -python-version:"3.15" | ||
| branch:"main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A possible improvement is to compute the branch and extra opts once and assign them to env vars:
| include: | |
| -python-version:"3.15" | |
| branch:"main" | |
| include: | |
| -python-version:"3.15" | |
| branch:"main" | |
| extra_opts:'--select-output no-html' | |
| env: | |
| # set the branch name to either 'main' or the version number | |
| BRANCH:${{ matrix.branch || matrix.version }} | |
| # define optional extra options if specified | |
| EXTRA_OPTS:${{ matrix.extra_opts || '' }} |
This keeps all the data and logic closer and avoids duplication. However we only need the branch and the extra opts once in the workflow, so your less-verbose solution is fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, that is quite a bit more verbose, let's stick with the current version. Thanks!
| --branches ${{ matrix.branch|| matrix.python-version}} | ||
| ${{ matrix.branch == 'main' && '--select-output no-html' || '' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| --branches ${{ matrix.branch || matrix.python-version }} | |
| ${{ matrix.branch == 'main' && '--select-output no-html' || '' }} | |
| --branches env.BRANCH env.EXTRA_OPTS |
4e36f99 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The earlier approach was something like:
Which do you prefer?
📚 Documentation preview 📚:https://python-docs-theme-previews--282.org.readthedocs.build/