Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update authors inpyproject.toml#271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 3 commits intopython:mainfromStanFromIreland:pyproject
Oct 24, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commentedSep 16, 2025•
edited by github-actionsbot
Loading

@hugovk
Copy link
Member

What's unnecessary, what's incorrect, and why?

AA-Turner reacted with thumbs up emoji

@AA-Turner
Copy link
Member

I agree with Hugo: when proposing a change, please provide appropriate context and rationale.

Here the git blame (at least via the UI) goes back to788b53d ('Initial version of theme'; Jon Wayne Parrott). I'm on mobile and can't do significant research, but that does probably seem to be an error -- but instead of removing it, shall we change it to say 'python-docs-theme maintainers', or 'python core devs', or whatever?

I would prefer to split the Ruff lint rules to a different file (I'm not a fan of putting random config in pyproject.toml), but I know Hugo has differing opinions here.

A

@StanFromIreland
Copy link
MemberAuthor

The lint rule exceptions are unnecessary since there are no infractions.

The distutils-sig being maintainers of this theme seems incorrect. I can change it to the "Python-docs-theme maintainers" Adam suggests.

@StanFromIrelandStanFromIreland changed the titleRemove unnecessary and incorrect sections frompyproject.tomlRemove unnecessary lint rules and update authors inpyproject.tomlSep 17, 2025
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The lint rule exceptions are unnecessary since there are no infractions.

No infractionsright now. If we remove the exceptions, a new PR can fail and the author will have to change their code to meet these rules. We don't want that.

pradyunsg reacted with thumbs up emoji
@StanFromIrelandStanFromIreland changed the titleRemove unnecessary lint rules and update authors inpyproject.tomlUpdate authors inpyproject.tomlSep 17, 2025
@hugovkhugovk merged commit89a8e83 intopython:mainOct 24, 2025
12 checks passed
@StanFromIrelandStanFromIreland deleted the pyproject branchOctober 24, 2025 15:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@hugovk@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp