Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork66
Make copybutton messages translatable#27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There's a little issue, the command gathering translations strings: won't pick it up, so translation teams won't see it as a sentence to translate. I don't have the timeright now to check if there's a simple way to solve this, maybe Sphinx has a way to look for translations strings in configured theme? |
I think I looked into this in the past and it was possible to directly translate the strings in the javascript file |
The following commit authors need to sign the Contributor License Agreement: |
I believe so, the button title is now properly i18n'd. |
This PR implements#23 which make the messages of copybutton (
>>>) translatable.When I tested my change using the master branch of Python (branch 3.7 doesn't seem to use python-docs-theme), I couldn't get it read my modified
layout.html. However, if I manually introduced the change, the pot files would include the new strings and the translation worked.I think it is better to have someone more familiar with the project structure of PEP 545 to test my implementation before it is merged.