Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Enable theme translation#246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 10 commits intopython:mainfromStanFromIreland:localize-theme
Sep 7, 2025
Merged

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commentedAug 7, 2025•
edited
Loading

Adds Polish to start. Based on@rffontenelle 's pr. This does not allow for translation of the Copy button for some reason, but I think that can be left for another time.

Result:

image

📚 Documentation preview 📚:https://python-docs-theme-previews--246.org.readthedocs.build/

🇵🇱 Polish preview 🇵🇱

@StanFromIrelandStanFromIreland marked this pull request as ready for reviewAugust 7, 2025 15:12
@StanFromIrelandStanFromIreland marked this pull request as draftAugust 7, 2025 15:13
@StanFromIrelandStanFromIreland marked this pull request as ready for reviewAugust 7, 2025 17:19
@StanFromIrelandStanFromIreland changed the titleLocalize themeEnable theme translationAug 7, 2025
@rffontenellerffontenelle mentioned this pull requestAug 7, 2025
@rffontenelle
Copy link
Contributor

Thanks for fixing what was missing with the solution!

StanFromIreland reacted with heart emoji

Copy link
Contributor

@m-aciekm-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Translation improvement suggestions, otherwise looks good to me 👍

Copy link
Contributor

@m-aciekm-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggestion for better portability

Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
yeager added a commit to yeager/python-docs-theme that referenced this pull requestAug 29, 2025
@yeageryeager mentioned this pull requestAug 29, 2025
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks about right, but I'd appreciate a PR approval from a translator as well.

And we can always iterate and fix as needed after an initial release.

@StanFromIreland
Copy link
MemberAuthor

Looks about right, but I'd appreciate a PR approval from a translator as well.

Maciek has already reviewed translation, see above.

@hugovk
Copy link
Member

Looks about right, but I'd appreciate a PR approval from a translator as well.

Maciek has already reviewed translation, see above.

Yes, but not approved.

@StanFromIreland
Copy link
MemberAuthor

In hopes of getting this in faster, I can just delete it?

Fun fact, translations of the Python docs are actually not reviewed for most languages.

@StanFromIreland
Copy link
MemberAuthor

Preview! (built with-D language='pl')

m-aciek reacted with rocket emoji

Copy link
Contributor

@m-aciekm-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! Thanks

@StanFromIreland
Copy link
MemberAuthor

It is no longer a follow up, it is now included in this PR!

Verified manually that theartefact has the compiled files.

hugovk reacted with rocket emoji

@rffontenelle
Copy link
Contributor

Sweet! Was setup-python really necessary, considering that python is already included in the GH runner image?

@StanFromIreland
Copy link
MemberAuthor

It is used in all other workflows in this repository when Python is needed.

hugovk reacted with thumbs up emoji

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@hugovkhugovk merged commit4f43ade intopython:mainSep 7, 2025
12 checks passed
@StanFromIrelandStanFromIreland deleted the localize-theme branchSeptember 7, 2025 17:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

+2 more reviewers

@rffontenellerffontenellerffontenelle left review comments

@m-aciekm-aciekm-aciek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@StanFromIreland@rffontenelle@hugovk@AA-Turner@m-aciek
[8]ページ先頭
©2009-2025 Movatter.jp