Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change root url to docs.python.org#220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
StanFromIreland wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromStanFromIreland:patch-1

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commentedFeb 2, 2025
edited by github-actionsbot
Loading

license_url =
root_name = Python
root_url = https://www.python.org/
root_url = https://www.docs.python.org/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This changes the default for every user of this theme. Should we usehtml_theme_options?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We could, also the link has to be docs.python.org as for some reason it is otherwise broken.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also coming back to this option, what do we set the default as?

@hugovk
Copy link
Member

Mobile

image

The logo always links todocs.python.org. That's okay when we're looking the 3.13 docs, but if we're looking at, say, 3.11 or 3.14, we'll end up at a different docs set which would be confusing.

Can it point to the same docs homepage we're looking at?

Desktop

With this change, these circled links both point to the docs homepage:

image

Before, the first one pointed towww.python.org, and the chevrons "»" indicated a hierarchy. Is it a bit odd that the upper level link is the same as the next one?

Or I guess, the top one isdocs.python.org and the next isdocs.python.org/3.x, so that's kind of a hierarchy, for the default case ofdocs.python.org >>docs.python.org/3, but maybe not really for, say,docs.python.org >>docs.python.org/3.11?

And do we want to lose the link towww.python.org?

The logo doesn't point to anything here.

m-aciek reacted with thumbs up emoji

@StanFromIreland
Copy link
MemberAuthor

I don't see a need for a button to python.org, it is linked when necessary.

@hugovk
Copy link
Member

We discussed this in the monthly docs workgroup meeting and decided to replace thewww.python.org link with adocs.python.org one.

We can add a link under "Project information:" towww.python.org.


Not brought up in the meeting, but as mentioned in#220 (comment), let's make sure the link doesn't go to the default docs.python.org for all docs versions; it should go to the homepage of that version.

For example, if on this page, the link should go to that page:

@hugovkhugovk mentioned this pull requestFeb 4, 2025
@python-cla-bot
Copy link

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs Python.org button

3 participants

@StanFromIreland@hugovk@AA-Turner

[8]ページ先頭

©2009-2025 Movatter.jp