Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Horizontally align the collapse button icon#219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 1 commit intopython:mainfromtomasr8:center-collapse-btn
Feb 3, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8tomasr8 commentedFeb 2, 2025
edited by github-actionsbot
Loading

Just something that was bugging me a bit :D I hope this won't be an issue regarding 4.x compatibility?

Before
image

After
image


📚 Documentation preview 📚:https://python-docs-theme-previews--219.org.readthedocs.build/

m-aciek, Wulian233, and Eclips4 reacted with heart emoji
@m-aciek
Copy link
Contributor

It may be worth checking how this affect Sphinx 4-, as Python 3.10 and 3.9 use Sphinx 3.4.3.

AA-Turner reacted with thumbs up emoji

/* after Sphinx 4.x and earlier is dropped, only the below is needed */
width: 12px;
border-radius: 0 5px 5px 0;
border-left: none;
}

#sidebarbutton span {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we achieve compatibility without deleting this?

@AA-Turner
Copy link
Member

It may be worth checking how this affect Sphinx 4-, as Python 3.10 and 3.9 use Sphinx 3.4.3.

Note I'm proposing pinningpython-docs-theme for the 3.10 and 3.11 branches inpython/cpython#129576. We already pinned for the 3.8 and 3.9 branches inpython/cpython#115349. However in the absence of that, this PR should be tested with 3.4.3, 7.2.6, and 8.1.3 ([ref]).

A

@tomasr8
Copy link
MemberAuthor

I'll test it later today or tomorrow (at Fosdem currently)

@tomasr8
Copy link
MemberAuthor

In addition to 8.1.3, I checked with 3.4.3 and 7.2.6 and both work as well :)

@AA-TurnerAA-Turner merged commit2f15ba6 intopython:mainFeb 3, 2025
15 checks passed
@tomasr8tomasr8 deleted the center-collapse-btn branchFebruary 3, 2025 19:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Wulian233Wulian233Wulian233 left review comments

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@tomasr8@m-aciek@AA-Turner@hugovk@Wulian233

[8]ページ先頭

©2009-2025 Movatter.jp