Horizontally align the collapse button icon#219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

AA-Turner merged 1 commit intopython:mainfromtomasr8:center-collapse-btn

Feb 3, 2025

Merged

Horizontally align the collapse button icon#219

AA-Turner merged 1 commit intopython:mainfromtomasr8:center-collapse-btn

Feb 3, 2025

Conversation

Copy link

Member

tomasr8 commentedFeb 2, 2025•
edited by github-actionsbot
Loading

Just something that was bugging me a bit :D I hope this won't be an issue regarding 4.x compatibility?

Before

After

📚 Documentation preview 📚:https://python-docs-theme-previews--219.org.readthedocs.build/

Align the collapse icon

c4e3c97

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we achieve compatibility without deleting this?

Copy link

Member

AA-Turner commentedFeb 2, 2025

It may be worth checking how this affect Sphinx 4-, as Python 3.10 and 3.9 use Sphinx 3.4.3.

Note I'm proposing pinningpython-docs-theme for the 3.10 and 3.11 branches inpython/cpython#129576. We already pinned for the 3.8 and 3.9 branches inpython/cpython#115349. However in the absence of that, this PR should be tested with 3.4.3, 7.2.6, and 8.1.3 ([ref]).