Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork74
Add colour to version change directives#185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
willingc left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@hugovk. I would love to see us move away from red and green. Since the wording is here too, I'm less concerned. When we work with an accessibility designer, we should come up with best practice light/dark themes for accessiblity.
Uh oh!
There was an error while loading.Please reload this page.
Similar to the sidebars inPEP 7 andPEP 8, we can add coloured sidebars and text to the version change directives.
Dark theme
Light theme
Accessibility check
versionremovedI also pre-emptively applied the red styling for the
versionremoveddirective, which will be released in the next Sphinx 7.3.0 (sphinx-doc/sphinx#11905).Comparison with other themes
This is similar to how theAwesome theme does it.
These themes also add a background colour:
AndNefertiti for Sphinx adds a coloured box around it.