Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove incorrect CSS property#178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pradyunsg merged 1 commit intopython:mainfromPrivat33r-dev:main
Mar 17, 2024
Merged

Conversation

Privat33r-dev
Copy link
Contributor

No description provided.

@hugovk
Copy link
Member

Yes, we should fix this :)

But should we fix it byremovingtext-size, and not reducing the font size? So essentially maintain the status quo? I think I prefer the bigger ">>>" button:

Status quo: not settingfont-size

image

https://python-docs-theme-previews.readthedocs.io/en/latest/tutorial/introduction.html#numbers

PR:font-size: 75%;

image

https://python-docs-theme-previews--178.org.readthedocs.build/en/178/tutorial/introduction.html#numbers

@Privat33r-dev
Copy link
ContributorAuthor

Privat33r-dev commentedMar 17, 2024
edited
Loading

From one point, it fixes the CSS, from the other point, it makes the element a bit small
image
image

As I was writing, you posted the same thing as well. I think that removal of thetext-size property would be more desirable and if 2 people have the same idea independently, I guess that it's a valid point.

P.S. I as well did my life harder by forgetting to make a new branch. Also I will use rebase this time because I forgot to setup my name, email and signing key.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@pradyunsg What do you think?

pradyunsg reacted with thumbs up emoji
@pradyunsgpradyunsg merged commit540a95c intopython:mainMar 17, 2024
@pradyunsg
Copy link
Member

@pradyunsg What do you think?

Good catch, and looks like this is good to merge! :)

hugovk and Privat33r-dev reacted with thumbs up emoji

@Privat33r-devPrivat33r-dev changed the titleCorrect invalid property nameRemove incorrect CSS propertyMar 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@pradyunsgpradyunsgpradyunsg approved these changes

@ezio-melottiezio-melottiezio-melotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Privat33r-dev@hugovk@pradyunsg@ezio-melotti

[8]ページ先頭

©2009-2025 Movatter.jp