Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Reduce underline offset#166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pradyunsg merged 2 commits intopython:mainfromhugovk:text-underline-offset
Jan 27, 2024
Merged

Conversation

hugovk
Copy link
Member

We added underlines in#160, with an offset to make sure they don't obscure underscores in code formatting. With fresh eyes, 0.3em looks a bit too much. Let's reduce it.

0.3em

image

0.2em

image

m-aciek reacted with thumbs up emoji
Copy link
Member

@ezio-melottiezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Have you tried checking this ona paragraph with lot of dunders?

ISTM that with0.2em the underline touches the underscores.
Maybe0.25em would be a good comprise?

@hugovk
Copy link
MemberAuthor

hugovk commentedJan 27, 2024•
edited
Loading

Here's a link to the build preview of that section:

https://python-docs-theme-previews--166.org.readthedocs.build/en/166/reference/datamodel.html#object.reversed

There is a small gap between the underscore and underline (Android/Chrome):

Screenshot_20240127_182017_Chrome

@hugovk
Copy link
MemberAuthor

macOS / Chrome:

0.2em

image

0.21em

image

0.22em

image

0.23em

image

0.24em

image

0.25em

image

@ezio-melotti
Copy link
Member

This is on Linux/Firefox:
0.2em:
image

0.25em:
image

0.3em:
image

I like0.25 -- with0.2 I have to do a double take because I'm not sure if there are two lines or I'm seeing double; with0.3 the difference is clear, but it does look a bit too distant (especially when there are no underscores); with0.25 the underline is closer to the text but I can still see the two lines distinctly. (Disclaimer, I'm running on 4h of sleep and my eyes are a bit tired, I can take a look again tomorrow -- maybe the0.2 will look better).

@hugovk
Copy link
MemberAuthor

0.25em looks okay to me, PR updated.

AA-Turner reacted with thumbs up emojiezio-melotti reacted with hooray emoji

@pradyunsgpradyunsg merged commitba55891 intopython:mainJan 27, 2024
@hugovkhugovk deleted the text-underline-offset branchJanuary 27, 2024 19:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ezio-melottiezio-melottiezio-melotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@hugovk@ezio-melotti@pradyunsg
[8]ページ先頭
©2009-2025 Movatter.jp