Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Consistently referencetheme_root_icon#163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 6 commits intopython:mainfrommbudisic:layout_reads_root_icon
Jan 12, 2024

Conversation

mbudisic
Copy link
Contributor

Removed explicitpy.svg references inlayout.html withtheme_root_icon paths.

This pull request changes paths lines 17 and 103 to match line 74 in the base branch.

Removed explicit py.svg references with theme_root_icon paths
@ghost
Copy link

ghost commentedJan 9, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@hugovk
Copy link
Member

Good idea.

Although "Logo" isn't a great alt text, can we also add something likeroot_icon_alt_text to the config?

ezio-melotti reacted with thumbs up emoji

… layout.htmlThis fixes a partial integration of root_icon and adds the new variable root_icon_alt_text
Capitalization fixCo-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

mbudisic reacted with thumbs up emoji
@mbudisic
Copy link
ContributorAuthor

Thank you for suggestions!

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Copy link
Member

@AA-TurnerAA-Turner left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Per thedocumentation:

This, however, is not the preferred way to concatenate strings! For string concatenation, have a look-see at the~ operator.

https://jinja.palletsprojects.com/en/3.1.x/templates/#other-operators

~ (tilde)

Converts all operands into strings and concatenates them.

As

mbudisic reacted with thumbs up emoji
@AA-TurnerAA-Turner changed the titlelayout.html references theme_root_icon consistentlyConsistently referencetheme_root_iconJan 12, 2024
@AA-TurnerAA-Turner merged commitbeb868f intopython:mainJan 12, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ezio-melottiezio-melottiezio-melotti approved these changes

@hugovkhugovkhugovk approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@mbudisic@hugovk@AA-Turner@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp