Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork66
Lint on GitHub Actions via pre-commit#159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
hugovk commentedOct 11, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I triggered a test run on https://github.com/python/python-docs-theme/actions/runs/6482294214/job/17601524907 Running the same command passes for me locally. |
| @@ -0,0 +1,2 @@ | |||
| [flake8] | |||
| max-line-length = 88 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can/should this specified with a --flag (or disabled ifblack already checks this)?
If we do we can get rid of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It could be done with a flag, but then it would only apply to that invocation with the flag, and not if we run Flake8 myself from the command line. This file means it is read by both.
We can't remove it either. Black will set some files to 88 chars wide, and then Flake8 would complain because it's over 80.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fair enough.
| @@ -0,0 +1,2 @@ | |||
| [flake8] | |||
| max-line-length = 88 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fair enough.
Add some pre-commit checks and apply autofixes. Also some minor config updates.
I also ranhttps://github.com/tox-dev/pyproject-fmt/ to reformat
pyproject.tomlto standardise it and make it much easier to compare with other repos. However, I didn't add it to pre-commit because it strips out the 3.13 classifier.