Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork66
Use correct block, enable built-in slash keypress#141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The CSS in the base template was updated to include this directive in #7695and released in sphinx v3.1.0.The original implementation was inpython#46, prior to the basic themeincluding it, and now we have the same meta tag duplicated.Remove the block, and reduce the duplication.Signed-off-by: Mike Fiedler <miketheman@gmail.com>
When the template was made responsive, the choice was made to overridethe `body_tag` fragment.The `body_tag` block is a literal `<body>` which allows the theme developerto set properties on the `body` tag.See:sphinx-doc/sphinx#4140Instead, use the `document` block as documented.https://www.sphinx-doc.org/en/master/development/templating.html#blocksOverriding the correct block places the `mobile-nav` section _after_ themajority of the other HTML parts, which enables the correct function ofthe `/` keyboard shortcut.Resolvespython#130Closespython#131Closespython#135Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Closed
@hugovk I think this one is the thing we want! |
Thanks! Preview:https://python-docs-theme-previews--141.org.readthedocs.build/en/141/ With this, slash highlights the search box in the top right in desktop view:  But not the one in mobile view:  Which is the more useful way around. |
hugovk approved these changesJul 27, 2023
This was referencedAug 5, 2023
Closed
This was referencedAug 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a commit removing a duplicate block.
When the template was made responsive, the choice was made to override
the
body_tagfragment.The
body_tagblock is a literal<body>which allows the theme developerto set properties on the
bodytag.See:sphinx-doc/sphinx#4140
Instead, use the
documentblock as documented.https://www.sphinx-doc.org/en/master/development/templating.html#blocks
Overriding the correct block places the
mobile-navsectionafter themajority of the other HTML parts, which enables the correct function of
the
/keyboard shortcut.Resolves#130
Closes#131
Closes#135