Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Don't duplicate the sidebar button on Sphinx 5 and newer#127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 3 commits intopython:mainfromAA-Turner:sphinx-5-fixup
Apr 25, 2023

Conversation

AA-Turner
Copy link
Member

The sidebar button is included in the generated HTML from Sphinx 5 onwards (specifically, fromsphinx-doc/sphinx@3b01fbe and the changes tothemes/classic/layout.html).

We use thesphinx_version_tuple templating variable addded in Sphinx 4.2 to determine if we should add the sidebar button dynamically via JavaScript, or load the pre-existing button element from HTML.

I have tested locally on Sphinx 6.1.3, Sphinx 3.2.0, and Sphinx 4.5.0--all three display correct behaviour with respect to the sidebar.

A

@AA-TurnerAA-Turner mentioned this pull requestApr 20, 2023
@AA-Turner
Copy link
MemberAuthor

I've updatedpython/cpython#99381 to point to this PR, so that it installs Sphinx 6.1.3 andpython-docs-theme as of this PR. Thedeploy preview seems to show that all is working as intended on newer Sphinx versions, and this PR's RTD preview shows it working on older Sphinx versions.

A

@hugovkhugovk merged commite3ef253 intopython:mainApr 25, 2023
@AA-Turner
Copy link
MemberAuthor

Thanks Hugo!

A

@AA-TurnerAA-Turner deleted the sphinx-5-fixup branchJuly 15, 2024 19:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@pradyunsgpradyunsgpradyunsg approved these changes

@JulienPalardJulienPalardAwaiting requested review from JulienPalard

Assignees

@AA-TurnerAA-Turner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@AA-Turner@hugovk@pradyunsg
[8]ページ先頭
©2009-2025 Movatter.jp