Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add matrix strategy to test with all supported Python versions#114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pradyunsg merged 1 commit intopython:mainfromm-aciek:test-on-all-py-versions
Mar 11, 2023

Conversation

m-aciek
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commentedMar 11, 2023
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@pradyunsg
Copy link
Member

I'll go ahead and merge this, on the basis that this seems like a good idea overall. Holler if you spot something off! :)

hugovk reacted with thumbs up emoji

@pradyunsgpradyunsg merged commit932b987 intopython:mainMar 11, 2023
@hugovk
Copy link
Member

Is it possible to add 3.12/main?

Should thedoc-html artifact athttps://github.com/python/python-docs-theme/actions/runs/4393087253 also include 3.8-3.10?

Left ismain, right is this PR:

image

@m-aciekm-aciek deleted the test-on-all-py-versions branchMarch 11, 2023 19:47
@m-aciek
Copy link
ContributorAuthor

Is it possible to add 3.12/main?

Yes, definitely, I think it's a good idea, I can add a pull request for that.

Should the doc-html artifact athttps://github.com/python/python-docs-theme/actions/runs/4393087253 also include 3.8-3.10?

Actually, we should see the jobs for 3.8-3.10 as failed, as my branch wasn't basing on fresh-fixed master. The missing artifacts were because of failed jobs. It looks like exit code ofbuild_docs.py script is incorrectly zero instead of non-zero for failing build. I will try to confirm that and follow it up in builddocs-script GitHub repository.

That's what the artifacts from the Actions on the theme main branch look like for me (all versions from matrix are there):

Zrzut ekranu 2023-03-11 o 21 16 18

@m-aciek
Copy link
ContributorAuthor

Please see PRpython/docsbuild-scripts#150.

hugovk and pradyunsg reacted with thumbs up emoji

@m-aciek
Copy link
ContributorAuthor

I just wanted to share a thought that in case of a need of some changes that would break backwards compatibility we can always decide to pin the theme version in CPython branch and remove a version from matrix. But still it will be easier to spot the breakage and pin the version in advance of releasing such changes having those tests in CI.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pradyunsgpradyunsgpradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@m-aciek@pradyunsg@hugovk

[8]ページ先頭

©2009-2025 Movatter.jp