Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Previews in pull requests#105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pradyunsg merged 3 commits intopython:mainfromhugovk:rtd-preview
Feb 13, 2023
Merged

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedJan 31, 2023
edited by pradyunsg
Loading

Fixes#70.

#70 suggested Read the Docs and Netlify, but we have a bit of a bus factor problem with Netlify on the CPython docs due to only having a single account that can access the admin, so let's use Read the Docs as well. We're using it successfully in the PEPs repo.

Here's a demo build:

Draft because:

And we need to set up Read the Docs:

@hugovkhugovk mentioned this pull requestJan 31, 2023
@hugovk
Copy link
MemberAuthor

Ping@Mariatta

@JDLH
Copy link

JDLH commentedFeb 6, 2023

I wasn't aware of the term "bus factor". For the information of others like me, it refers to a risk that critical roles in a project are limited to a small number of people, in the sense of "in case they get hit by a bus". There is a nice Wikipedia article,Bus factor.

hugovk reacted with thumbs up emoji

@hugovkhugovk changed the titleBuild CPython docs on Read the DocsPreviews in pull requestsFeb 6, 2023
@Mariatta
Copy link
Member

Project created:https://readthedocs.org/projects/python-docs-theme-previews/

Who else should I add as maintainers?

hugovk reacted with thumbs up emoji

@hugovk
Copy link
MemberAuthor

Thanks! Maybe@JulienPalard,@ezio-melotti and me?

Mariatta reacted with heart emoji

@pradyunsg
Copy link
Member

I'd be happy to be listed as well, if we don't have enough people. :)

Mariatta and hugovk reacted with heart emoji

@Mariatta
Copy link
Member

I'll need your readthedocs usernames:@hugovk,@pradyunsg,@JulienPalard,@ezio-melotti

@pradyunsg
Copy link
Member

I'mpradyunsg (perhaps, unsurprisingly).

Mariatta reacted with thumbs up emoji

@hugovk
Copy link
MemberAuthor

I'mhugovk (perhaps, unsurprisingly).

Mariatta reacted with thumbs up emoji

@Mariatta
Copy link
Member

Invites sent.

hugovk reacted with rocket emoji

@hugovk
Copy link
MemberAuthor

I'll close this and re-open it as a new PR, and hopefully it will trigger an RTD build 🤞

@hugovkhugovk closed thisFeb 7, 2023
@hugovkhugovk mentioned this pull requestFeb 7, 2023
@hugovk
Copy link
MemberAuthor

Nope, didn't trigger for#107, re-opening this.

It worked on my fork, I'll compare settings:

@hugovkhugovk reopened thisFeb 7, 2023
@hugovk
Copy link
MemberAuthor

OK, so the incoming GitHub webhook is good on my fork (athttps://readthedocs.org/dashboard/hugovk-python-docs-theme/integrations/225260/):

Detailsimage

And I also see a webhook (athttps://github.com/hugovk/python-docs-theme/settings/hooks):

Detailsimage

But not for this repo (athttps://readthedocs.org/dashboard/python-docs-theme-previews/integrations/225787/):

Detailsimage

If I click "Resync webhook" I get "Webhook activation failed. Make sure you have the necessary permissions", which makes sense as I don't have admin permissions here.


@Mariatta Please can you try the "Resync webhook" button athttps://readthedocs.org/dashboard/python-docs-theme-previews/integrations/225787/?

And is there anything athttps://github.com/python/python-docs-theme/settings/hooks?

@hugovk
Copy link
MemberAuthor

Łukasz has enabled we hooks. 🎣

Close/re-open to retrigger...

@hugovkhugovk closed thisFeb 7, 2023
@hugovkhugovk reopened thisFeb 7, 2023
@hugovkhugovk marked this pull request as ready for reviewFebruary 7, 2023 21:37
@hugovk
Copy link
MemberAuthor

Deploy preview is now built!

Ready for review!

https://python-docs-theme-previews--105.org.readthedocs.build/en/105/

@pradyunsgpradyunsg merged commit506e0f2 intopython:mainFeb 13, 2023
@hugovkhugovk deleted the rtd-preview branchFebruary 13, 2023 11:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pradyunsgpradyunsgpradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Previews in pull requests
4 participants
@hugovk@JDLH@Mariatta@pradyunsg

[8]ページ先頭

©2009-2025 Movatter.jp