python/python-docs-themePublic

NotificationsYou must be signed in to change notification settings
Fork68
Star80

Fix problem with monospace rendering in Vivaldi#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hugovk merged 1 commit intopython:mainfromZedThree:fix-monospace-vivaldi

Feb 6, 2023

Merged

Fix problem with monospace rendering in Vivaldi#104

hugovk merged 1 commit intopython:mainfromZedThree:fix-monospace-vivaldi

Feb 6, 2023

Conversation

Copy link

Contributor

ZedThree commentedJan 30, 2023

Fixes#98

Fix problem with monospace rendering in Vivaldi

15c8fc9

Fixespython#98

Copy link

ghost commentedJan 30, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.

ezio-melotti reviewed

Jan 30, 2023

View reviewed changes

Copy link

Member

ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What browsers have you tested this with?
Do we know why the quoted `"monospace" was included and should we keep it somewhere in the list?

Copy link

Member

hugovk commentedJan 31, 2023

Quoted "monospace" was added in#85 to workaround a Chrome bug, which was fixed in Chrome 96 (Nov 2021):python/pythondotorg#1708 (comment).

By now, there's very little usage of Chrome 96 and older versions. Chrome 96% is 0.04% athttps://caniuse.com/usage-table, and it's something like 1.68% for 96 and older.

(It would be good if we could hook up PR previews on Read the Docs or Netlify, that would make testing easier.)

Copy link

ContributorAuthor

ZedThree commentedJan 31, 2023

I tested with Vivaldi 5.6.2867.62 and Firefox 109.0

hugovk approved these changes

Jan 31, 2023

View reviewed changes

Copy link

Member

hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tested building CPython docs locally using:

diff --git a/Doc/requirements.txt b/Doc/requirements.txtindex 134f39d6d7..c6d9c6a663 100644--- a/Doc/requirements.txt+++ b/Doc/requirements.txt@@ -12,4 +12,4 @@ sphinxext-opengraph>=0.7.1  # The theme used by the documentation is stored separately, so we need # to install that as well.-python-docs-theme>=2022.1+git+https://github.com/ZedThree/python-docs-theme@fix-monospace-vivaldi#egg=python-docs-theme

Looks fine on macOS Ventura 13.1 and Chrome 108: