Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Initial version of theme.#1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ncoghlan merged 2 commits intomasterfrominitial-version
Jun 9, 2017
Merged

Initial version of theme.#1

ncoghlan merged 2 commits intomasterfrominitial-version
Jun 9, 2017

Conversation

theacodes
Copy link
Collaborator

Extracted from CPython @ 1bced5656

Added a few more theme config values, split the donate footer into its own template, and removed CPython-docs sepcific JavaScript and HTML.

Extracted from CPython @ 1bced5656Added a few more theme config values, split the donate footer into its own template, and removed CPython-docs sepcific JavaScript and HTML.
@theacodes
Copy link
CollaboratorAuthor

@brettcannon FYI I have a working version of the CPython docs that use this theme (and removes duplicated code), should I send that over to CPython after this is merged? :)

willingc reacted with thumbs up emoji

@brettcannon
Copy link
Member

@jonparrott sure

Copy link
Contributor

@ncoghlanncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mostly looks good to me, just the extra README paragraph requested, and a question about the use of theio module insetup.py

README.rst Outdated
Python Docs Sphinx Theme
=========================

This is the theme for the Python documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The note from the python-dev discussion can just be added here as a second paragraph:

Note that when adopting this theme, you're also borrowing an element of the trust and credibility established by the CPython core developers over the years. That's fine, and you're welcome to do so for other Python community projects if you so choose, but please keep in mind that in doing so you're also choosing to accept some of the responsibility for maintaining that collective trust.

willingc reacted with thumbs up emoji
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done, thank you. :)

from setuptools import setup

# README into long description
with io.open('README.rst', encoding='utf-8') as readme_file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are we planning to support installing this theme for use in Py2 docs builds? If not, we can just use the open() builtin directly here, rather than going through theio module.

Copy link
CollaboratorAuthor

@theacodestheacodesJun 7, 2017
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Although this is technically for the Python 3 docs, usingio.open overopen is pretty cheap for us, especially considering this package contains almost no Python code. :)

@theacodes
Copy link
CollaboratorAuthor

@ncoghlan please take another look when you get a chance. :)

Copy link
Contributor

@ncoghlanncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me!

@theacodes
Copy link
CollaboratorAuthor

theacodes commentedJun 9, 2017 via email

Thanks!
On Thu, Jun 8, 2017, 8:21 PM Nick Coghlan ***@***.***> wrote: Merged#1 <#1>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc0au4b50AlsiQuHwRBl9BqAy0Oa_ks5sCLozgaJpZM4NwmdZ> .

@zwarezware deleted the initial-version branchDecember 10, 2019 23:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ncoghlanncoghlanncoghlan approved these changes

@brettcannonbrettcannonAwaiting requested review from brettcannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@theacodes@brettcannon@ncoghlan

[8]ページ先頭

©2009-2025 Movatter.jp