Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve ci#40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
methane merged 7 commits intopython:3.10fromrffontenelle:improve-CI
Dec 30, 2022
Merged

Improve ci#40

methane merged 7 commits intopython:3.10fromrffontenelle:improve-CI
Dec 30, 2022

Conversation

rffontenelle
Copy link
Contributor

  • Use the new Transifex CLI toll: The Python implementation named transifex-client uses Transifex's APIv2, which is deprecated and will sunset in november 2022. The new tool, called Transifex CLI, is written in Golang and is APIv3-ready. So adjusting the CI and requirements.txt is required.
  • Fix condition in the merge job]: Having the proper condition is important to have the translation
    update in the latest Python version (python-newest project), and
    the condition wouldn't match the current repository.

The Python implementation named transifex-client uses Transifex'sAPIv2, which is deprecated and will sunset in november 2022.The new tool, called Transifex CLI, is written in Golang and isAPIv3-ready. So adjusting the CI and requirements.txt is required.
Having the proper condition is important to have the translationupdate in the latest Python version (python-newest project), andthe condition wouldn't match the current repository.
Copy link
Contributor

@m-aciekm-aciek left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

New Transifex CLI doesn't supportTX_TOKEN environment variable whichupdate.sh/GH Action uses. [1]

We should update this line [2] to contain the Transifex API token.

~~ ~~tx --token ${TX_TOKEN} pull -l ${LANGUAGE} --use-git-timestamps --parallel~~ ~~

[1]transifex/cli#116
[2]https://github.com/python/python-docs-ja/blob/3.10/scripts/update.sh#L42

EDIT: One comment. Otherwise looks good to me 👍 .

To avoid having LICENSE in checkout directoryCo-authored-by: Maciej Olko <maciej.olko@affirm.com>
@rffontenelle
Copy link
ContributorAuthor

@m-aciek Thanks for the suggestion.

@m-aciek
Copy link
Contributor

Possibly we also need to change format of .tx/config file for new CLI. Is it generated automatically?

@rffontenelle
Copy link
ContributorAuthor

@m-aciek Currently .tx/config is recreated when scripts/update.sh runs the sed command outputting to .tx/config. Still, some changes are necessary to fit the new tx client, so thanks for bringing this up.

m-aciek reacted with thumbs up emoji

Last released sphinx-intl uses old transifex-client, which usesthe deprecated Transifex APIv2. There is a fix committed, butit is unreleased. So using specific commit where new TransifexCLI tool works.
Previous solution of patching .tx/config does not work with thenew client, so the script had to be updated with new solution.Now, translations are pulled into a sub-directory of cpython, andthen installed in the languages's repository.Also using 'realpath' tool in ROOTDIR to retrieve absolute path,which actually eases referencing the repository root directory.
One of the reason is that some of them use node.js 12, which isnow deprecated. Actions is displaying warnings about it.v4 of setup-python is particular useful because it introducespackage caching, which reduces the time of workflow run.
Source files auto-update is now done elsewhere
@rffontenelle
Copy link
ContributorAuthor

The last commit disables pushing source files to Transifex (tx push) because translations are now updated viarffontenelle/docspush-transifex, as discussed inPython's translation mailing list.

m-aciek and methane reacted with thumbs up emoji

@methanemethane merged commitff06042 intopython:3.10Dec 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@m-aciekm-aciekm-aciek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@rffontenelle@m-aciek@methane

[8]ページ先頭

©2009-2025 Movatter.jp