Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added another step on contributing.md to avoid pip install issue#571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lysnikolaou merged 2 commits intopython:3.12frommgiannopoulos24:fix/contributing
Dec 9, 2024

Conversation

mgiannopoulos24
Copy link
Contributor

Ποιο issue κλείνει το συγκεκριμένο PR;

Closes#569

Περιγραφή του PR

Προστέθηκε ένα επιπλέον βήμα στοCONTRIBUTING.md το οποίο θα μας συμβουλεύει να χρησιμοποιήσουμε και το παρακάτω command ώστε να κάνουμε clone και το cpython ολόκληρο.

git submodule update --init

@mgiannopoulos24mgiannopoulos24 requested a review froma team as acode ownerDecember 9, 2024 10:58
Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@mgiannopoulos24! Έκανα 2 comments για κάποια improvements. Ψιλό-άσχετα με το συγκεκριμένο PR, οπότε αν θες να κάνουμε merge αυτό και δουλεύουμε στα points μου σε ένα καινούριο (αν θες, μπορώ να τα κάνω κι εγώ, ό,τι προτιμάς).

@mgiannopoulos24
Copy link
ContributorAuthor

εντάξει θα το φτιάξω εγώ.

lysnikolaou reacted with heart emoji

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks@mgiannopoulos24!

@lysnikolaoulysnikolaou merged commit610850f intopython:3.12Dec 9, 2024
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lysnikolaoulysnikolaoulysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty cpython directory after cloning.
2 participants
@mgiannopoulos24@lysnikolaou
[8]ページ先頭
©2009-2025 Movatter.jp