Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Introduce devcontainers configuration#564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

gmargaritis
Copy link
Collaborator

Added devcontainers support

Added the following make commands

  1. make http-serve: serve the translation preview on a webserver
  2. make preview: builds and serves the translation preview by openingindex.html on the user's browser
  3. make http-preview: builds and serves the translation preview a webserver
  4. make lint: runspowrap andcheck_spellcheck.py on all.po files

@pygreece/translation I'd vouch to only keep thehttp-preview command for serving the translation preview.

thepetk and skpanagiotis reacted with heart emoji
@gmargaritisgmargaritis requested a review froma team as acode ownerNovember 21, 2024 16:00
@gmargaritisgmargaritisenabled auto-merge (squash)November 21, 2024 18:29
@gmargaritisgmargaritisforce-pushed theintroduce-devcontainers-config branch fromd9ba86e toe9a0e1eCompareNovember 21, 2024 18:42
@gmargaritis
Copy link
CollaboratorAuthor

Removedhttp-serve andhttp-preview and kept their functionality as the default one in the pre-existing commands, i.e.serve,preview.

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The devcontainer config looks good. Left a couple comments on the Makefile changes and the contributing guide.

gmargaritis reacted with rocket emoji
@skpanagiotis
Copy link
Collaborator

@gmargaritis πολύ καλή δουλειά, και πιστεύω ότι είναι κάτι που θα εξυπηρετήσει. Εγώ προσωπικά, δεν έχω κάτι να προσθέσω μου φαίνεται μια χαρά, και είναι πολύ καλό που έχουμε 2 τρόπους σεταρίσματος του έργου.

gmargaritis reacted with heart emoji

@gmargaritisgmargaritis requested a review froma teamNovember 29, 2024 09:52
Copy link
Collaborator

@skpanagiotisskpanagiotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Πιστεύω ότι μπορεί να ενσωματωθεί ως τρόπος.

artemislnand others added3 commitsDecember 4, 2024 15:29
* Translated distributing/index.po* Update index.po* Update index.po* [pre-commit.ci lite] apply automatic fixes---------Co-authored-by: = <=>Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>Co-authored-by: skpanagiotis <panagiotis.skias@gmail.com>
@gmargaritisgmargaritis changed the base branch frommain to3.12December 11, 2024 10:20
@gmargaritis
Copy link
CollaboratorAuthor

@lysnikolaou Can you do a double check and approve this one?

lysnikolaou
lysnikolaou previously approved these changesFeb 20, 2025
Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Δύο πολύ minor comments.

gmargaritis reacted with heart emoji
Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@gmargaritisgmargaritis merged commit83bec33 intopython:3.12Feb 20, 2025
1 of 2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@skpanagiotisskpanagiotisskpanagiotis left review comments

@lysnikolaoulysnikolaoulysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@gmargaritis@skpanagiotis@lysnikolaou@artemisln@mgiannopoulos24
[8]ページ先頭
©2009-2025 Movatter.jp