python/python-docs-grPublic

NotificationsYou must be signed in to change notification settings
Fork16
Star20

Update Contributing Guide#561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

skpanagiotis merged 23 commits intopython:mainfromskpanagiotis:ft/contributing-guide

Nov 21, 2024

Merged

Update Contributing Guide#561

skpanagiotis merged 23 commits intopython:mainfromskpanagiotis:ft/contributing-guide

Nov 21, 2024

Conversation

Copy link

Collaborator

skpanagiotis commentedNov 11, 2024

Ποιο issue κλείνει το συγκεκριμένο PR;

Closes#548

Περιγραφή του PR

Βελτίωση του Contributing Guide για να είναι πιο κατανοητός ο τρόπος που γίνεται συνεισφορά στο έργο της μετάφρασης.

skpanagiotis added5 commits

November 7, 2024 09:51

Update and Add images

bb5febe

Update Contributing.md

6a1088b

Add images

fbf798d

Update Contributing.md

436b5bc

Minor in contributing.md

3c764ed

skpanagiotis requested review fromthepetk,lysnikolaou andgzisopoulos ascode owners

November 11, 2024 07:40

thepetk reviewed

Nov 11, 2024

View reviewed changes

Copy link

Collaborator

thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Κάποια μικρά suggestions αφησα μόνο!

CONTRIBUTING.md OutdatedShow resolvedHide resolved

CONTRIBUTING.mdShow resolvedHide resolved

CONTRIBUTING.md OutdatedShow resolvedHide resolved

skpanagiotisand others added3 commits

November 11, 2024 23:22

Update CONTRIBUTING.md

9d90180

Co-authored-by: Theofanis Petkos <thepetk@gmail.com>

Update CONTRIBUTING.md

ee204ef

Co-authored-by: Theofanis Petkos <thepetk@gmail.com>

Update CONTRIBUTING.md

a16387b

Co-authored-by: Theofanis Petkos <thepetk@gmail.com>

vadal reviewed

Nov 14, 2024

View reviewed changes

CONTRIBUTING.md OutdatedShow resolvedHide resolved

Minor changes in Contributing Guide

be244b4

thepetk previously approved these changes

Nov 18, 2024

View reviewed changes

Copy link

Collaborator

thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

Copy link

Contributor

gzisopoulos commentedNov 18, 2024

Οταν κάνει κάποιος fork ενα repository αυτο εχει προεπιλεγμενο να κάνει copy μονο το main branch. Αν ακολουθησει καποιος τα βηματα με το main branch τοτε όταν κανειpip install -r requirements.txt θα πάρει error γιατι το cpython directory ειναι κενο. Οποτε ισως πρέπει να τους γράψουμε να κανουν fetch πρωτα και checkout στο 3.12 πριν κανουν install τα requirements ή να ξεκλικαρουν το μονο το main branch οταν κανουν fork και να χρειαζονται μονο ενα checkout πριν γινουν install τα requirements.

Copy link

CollaboratorAuthor

skpanagiotis commentedNov 19, 2024

Σωστή αυτή η παρατήρηση@gzisopoulos . Για αυτό πρέπει να γίνει default branch μας το 3.12 αφού γίνει merge με το master.

Copy link

Contributor

gzisopoulos commentedNov 19, 2024

Επισης τοscripts/check_spelling.py είναι στο main branch και δεν υπάρχει στο 3.12 απο το οποιο γινεται το checkout για το καινουριο branch με τη μεταφραση που θα ανεβασει ο χρήστης.

gzisopoulos closed this

Nov 19, 2024

skpanagiotis reopened this

Nov 19, 2024

gmargaritis requested changes

Nov 19, 2024

View reviewed changes

Copy link

Collaborator

gmargaritis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Πολύ καλές αλλαγές! Kudos to everyone 🎉

CONTRIBUTING.md OutdatedShow resolvedHide resolved

skpanagiotisand others added6 commits

November 20, 2024 09:32

Update CONTRIBUTING.md

a4df9bc

Co-authored-by: George Margaritis <gmargaritis@protonmail.com>

Update CONTRIBUTING.md

0924858

Co-authored-by: George Margaritis <gmargaritis@protonmail.com>

Update CONTRIBUTING.md

38f98bc

Co-authored-by: George Margaritis <gmargaritis@protonmail.com>

Update CONTRIBUTING.md

0d2262d

Co-authored-by: George Margaritis <gmargaritis@protonmail.com>

Update CONTRIBUTING.md

ec584aa

Co-authored-by: George Margaritis <gmargaritis@protonmail.com>

Fix headers and links in Contributing.md

b21f372

gmargaritis previously approved these changes

Nov 20, 2024

View reviewed changes

Copy link

Collaborator

gmargaritis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚀

skpanagiotis dismissedthepetk’sstale review viab21f372

November 20, 2024 09:04

lysnikolaou reviewed

Nov 20, 2024

View reviewed changes

Copy link

Member

lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@skpanagiotis and everyone, amazing work! Thanks a lot for doing this!

A couple of comments (here and inline):

Can we add a second command to the 4th step of setting up. Aftergit remote add upstream, it'd be best if contributors also didgit remote set-url --push upstream git@github.com:<your-username>/cpython.git to avoid accidentally pushing to the upstream repo.

CONTRIBUTING.md OutdatedShow resolvedHide resolved

Update CONTRIBUTING.md

6762ebd

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

skpanagiotis dismissedgmargaritis’sstale review via6762ebd

November 20, 2024 13:54

skpanagiotisand others added5 commits

November 20, 2024 15:54

Update CONTRIBUTING.md

1d6294d

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

Update CONTRIBUTING.md

ab69404

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

Update CONTRIBUTING.md

10f087a

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

Update CONTRIBUTING.md

ea17d44

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

Add extra step

21cb128

skpanagiotis requested a review froma team as acode owner

November 20, 2024 15:22

Copy link

CollaboratorAuthor

skpanagiotis commentedNov 20, 2024

Πρόσθεσα και το extra βήμα του@lysnikolaou

Minor fix in CONTRIBUTING.md

884cf49

lysnikolaou reviewed

Nov 20, 2024

View reviewed changes

Copy link

Member

lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks everyone!

CONTRIBUTING.md OutdatedShow resolvedHide resolved

Update CONTRIBUTING.md

4d2541d

Copy link

Member

lysnikolaou commentedNov 20, 2024

Pushed the nitty comment I made above, I think we're good to merge at this point.

skpanagiotisenabled auto-merge (squash)

November 21, 2024 07:56

lysnikolaou reviewed

Nov 21, 2024

View reviewed changes

Copy link

Member

lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approving so that the button turns green.

lysnikolaou approved these changes

Nov 21, 2024

View reviewed changes

Copy link

Member

lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approving so that the button turns green.

skpanagiotisdisabled auto-merge

November 21, 2024 07:56

gzisopoulos approved these changes

Nov 21, 2024

View reviewed changes

skpanagiotis merged commita39daa7 intopython:main

Nov 21, 2024

2 checks passed

skpanagiotis deleted the ft/contributing-guide branch

December 16, 2024 18:41

Labels

None yet

6 participants

Movatterモバイル変換

Uh oh!

Update Contributing Guide#561

Update Contributing Guide#561

Uh oh!

Conversation

skpanagiotis commentedNov 11, 2024

Ποιο issue κλείνει το συγκεκριμένο PR;

Περιγραφή του PR

Uh oh!

thepetk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thepetk left a comment

Choose a reason for hiding this comment

Uh oh!

gzisopoulos commentedNov 18, 2024

Uh oh!

skpanagiotis commentedNov 19, 2024

Uh oh!

gzisopoulos commentedNov 19, 2024

Uh oh!

gmargaritis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmargaritis left a comment

Choose a reason for hiding this comment

Uh oh!

lysnikolaou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skpanagiotis commentedNov 20, 2024

Uh oh!

lysnikolaou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lysnikolaou commentedNov 20, 2024

Uh oh!

lysnikolaou left a comment

Choose a reason for hiding this comment

Uh oh!

lysnikolaou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!