Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Mejorando la guía de revisión#964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
silvinabt87 merged 13 commits into3.8fromclacri-guiarevision
Oct 6, 2020
Merged

Conversation

clacri
Copy link
Contributor

@clacriclacri commentedOct 6, 2020•
edited
Loading

Closes#953

@clacriclacri marked this pull request as draftOctober 6, 2020 07:34
@clacriclacri marked this pull request as ready for reviewOctober 6, 2020 08:16
Copy link
Collaborator

@cmaureircmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Para esconder el link en texto y que no quede el link completo como texto.

Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Copy link
Collaborator

@raulcdraulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Dos minor comments. Un typo que he encontrado y una sugerencia que no es necesaria.

@raulcd
Copy link
Collaborator

No lo he dicho en la review pero me gusta mucho 👍

clacri reacted with heart emoji

clacriand others added2 commitsOctober 6, 2020 10:56
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@raulcd
Copy link
Collaborator

no la mergeo,@silvinabt87 dale un vistazo y si te parece bien mergeas

Copy link
Collaborator

@humitoshumitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Excellent!

clacriand others added3 commitsOctober 6, 2020 11:25
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Copy link
Collaborator

@cmaureircmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hay que mirar lo del link primero

Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir
Copy link
Collaborator

ahora si funciona el rendering del link :)

@clacri
Copy link
ContributorAuthor

me faltaria lo de las secciones ahora lo miro

@clacri
Copy link
ContributorAuthor

Creo que pinta mejora ahora :)https://python-docs-es--964.org.readthedocs.build/es/964/reviewers-guide.html si encontrais alguna cosa más que mejorar dejadmelo por aqui :)

Copy link
Collaborator

@humitoshumitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Quedó pefecta!

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Copy link
ContributorAuthor

@clacriclacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sugerencia

@silvinabt87
Copy link
Collaborator

Quedó genial!!

@silvinabt87silvinabt87 merged commit87d4336 into3.8Oct 6, 2020
@cmaureircmaureir deleted the clacri-guiarevision branchDecember 10, 2021 13:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@humitoshumitoshumitos approved these changes

@cmaureircmaureircmaureir approved these changes

@raulcdraulcdraulcd approved these changes

@silvinabt87silvinabt87Awaiting requested review from silvinabt87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completar la guia de revisión
5 participants
@clacri@raulcd@cmaureir@silvinabt87@humitos
[8]ページ先頭
©2009-2025 Movatter.jp