- Notifications
You must be signed in to change notification settings - Fork395
Create reviewers guide#550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Gracias por este PR@silvinabt87 :)
| Cuatro razones por las que puede fallar el *build* de Travis: | ||
| * Powrap falla | ||
| * Pospell falla | ||
| * Dict está duplicado |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| * Dict está duplicado | |
| * Dict está duplicado |
Creo que el cambio que se quiere implementar dedict por archivo, esto ya no sería necesario.
Uh oh!
There was an error while loading.Please reload this page.
.overrides/reviewers-guide.rst Outdated
| * Powrap falla | ||
| * Pospell falla | ||
| * Dict está duplicado | ||
| * Sphinx falla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Acá habría que hacer la diferencia de los warnings, y los errores que a veces hay.
Yo creo que es muy buen comienzo, para mí si incluyes las sugerencias de Cristian yo haría merge ya de este PR y luego se puede mejorar pero al menos tenemos ya una pequeña introducción y un recuros para que la agente se anime con los PR, que tenemos muuuchos :) La dejo aprobada también, avisadme para mergear si quereis una vez incluidos esos cambios. |
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
This PR creates an initial reviewers guide to be updated and modified by other reviewers with tips/guidance.
Closes#399