python/python-docs-esPublic

NotificationsYou must be signed in to change notification settings
Fork396
Star348

Traducido library/ast#484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

cmaureir merged 5 commits intopython:3.8fromcmaureir:traduccion-library-ast

Jul 26, 2020

Merged

Traducido library/ast#484

cmaureir merged 5 commits intopython:3.8fromcmaureir:traduccion-library-ast

Jul 26, 2020

Conversation

Copy link

Collaborator

cmaureir commentedJun 28, 2020

Closes#469

cmaureirand others added2 commits

June 29, 2020 00:38

Traducido library/ast

9186d8a

Merge branch '3.8' into traduccion-library-ast

9700f91

narvmtz reviewed

Jul 25, 2020

View reviewed changes

Copy link

Contributor

narvmtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

¡Muchas gracias@cmaureir!

Dejé algunas sugerencias y con eso, creo quedaría listo el archivo :)

library/ast.po OutdatedShow resolvedHide resolved

library/ast.po

Comment on lines +144 to +145

		"`end_col_offset` son las correspondientes compensaciones de bytes UTF-8 del "
		"primer y último token que generó el nodo. El desplazamiento UTF-8 se "

Copy link

Contributor

narvmtzJul 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	"`end_col_offset` son las correspondientes compensaciones de bytes UTF-8 del"
	"primer y último token que generó el nodo. El desplazamiento UTF-8 se"
	"`end_col_offset` son las correspondientes compensaciones de bytes UTF-8 del"
	"primer y último token que generó el nodo. El desplazamiento UTF-8 se"

Acá usas "compensaciones" y "desplazamiento" para "offsets", te parece si lo estandarizamos por alguno que encaje en ambas líneas?

library/ast.po


		#: ../Doc/library/ast.rst:84
		msgid ""
		"If there are keyword arguments, they will set the attributes of the same "
		"names to the given values."
		msgstr ""
		"Si hay argumentos de palabras clave, establecerán los atributos de los "

Copy link

Contributor

narvmtzJul 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	"Si hay argumentosde palabras clave, establecerán los atributos de los"
	"Si hay argumentospor palabras clave, establecerán los atributos de los"

Copy link

CollaboratorAuthor

cmaureirJul 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

al final decidimos aceptar los dos :P "por" y "de"

library/ast.po OutdatedShow resolvedHide resolved

narvmtz suggested changes

Jul 25, 2020

View reviewed changes

Copy link

Contributor

narvmtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Encontré una última cosita :)

library/ast.po OutdatedShow resolvedHide resolved

Apply suggestions from code review

907c34c

Co-authored-by: narvmtz <51009725+narvmtz@users.noreply.github.com>

Copy link

Contributor

narvmtz commentedJul 25, 2020

Solo faltaría hacerle powrap y creo que con eso pasaría Travis :)

cmaureir added2 commits

July 26, 2020 09:42

Merge remote-tracking branch 'upstream/3.8' into traduccion-library-ast

9cad80b

powrap library/ast

cec7b1e

cmaureir requested a review fromnarvmtz

July 26, 2020 07:50

Copy link

CollaboratorAuthor

cmaureir commentedJul 26, 2020

@narvmtz cuando le des approve mergeamos este :)

narvmtz approved these changes

Jul 26, 2020

View reviewed changes

cmaureir merged commit80bbf94 intopython:3.8

Jul 26, 2020

cmaureir deleted the traduccion-library-ast branch

July 26, 2020 13:39

Labels

None yet

2 participants

Movatterモバイル変換

Traducido library/ast#484

Traducido library/ast#484

Uh oh!

Conversation

cmaureir commentedJun 28, 2020

Uh oh!

narvmtz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

narvmtzJul 25, 2020

Choose a reason for hiding this comment

Uh oh!

narvmtzJul 25, 2020

Choose a reason for hiding this comment

Uh oh!

cmaureirJul 25, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

narvmtz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

narvmtz commentedJul 25, 2020

Uh oh!

cmaureir commentedJul 26, 2020

Uh oh!

Uh oh!