Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix dict_dups check#374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
humitos merged 1 commit into3.8fromfix_check_dups
May 29, 2020
Merged

fix dict_dups check#374

humitos merged 1 commit into3.8fromfix_check_dups
May 29, 2020

Conversation

gilgamezh
Copy link
Collaborator

@gilgamezhgilgamezh commentedMay 26, 2020
edited
Loading

Fix para el check de duplicados.

@humitos estaba proponiendo removerlo. Yo creo que nos agrega un mínimo chequeo de que alguien no agrega mil cosas random. Pero si les parece que no aporta lo sacamos.

Alguien sabe cómo agregar un comando bash en un pre-commit? podríamos moverlo ahí tal vez.

Si les parece mejor sacarlo avisen y lo hago en este PR

@clacri
Copy link
Contributor

a mi me gustaria ponerlo en pre-commit pero no tengo ni idea de como funciona, y de hecho me gustaria aprenderlo, asi que si lo haceis así, me encantaría participar!

@humitos
Copy link
Collaborator

Voy haciendo el merge de esto ya que roto en Travis actualmente y le da problemas a las nuevas PRs. Luego vemos lo de pre-commit o si lo quitamos.

@humitoshumitos merged commit7fc7f59 into3.8May 29, 2020
@humitoshumitos deleted the fix_check_dups branchMay 29, 2020 10:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@clacriclacriclacri approved these changes

@humitoshumitosAwaiting requested review from humitos

@raulcdraulcdAwaiting requested review from raulcd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@gilgamezh@clacri@humitos

[8]ページ先頭

©2009-2025 Movatter.jp