Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

3.13 build comments#3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaureir merged 3 commits intopython:3.13fromrtobar:3.13
Nov 22, 2024
Merged

3.13 build comments#3300

cmaureir merged 3 commits intopython:3.13fromrtobar:3.13
Nov 22, 2024

Conversation

rtobar
Copy link
Collaborator

@rtobarrtobar commentedNov 22, 2024
edited
Loading

Detalles en los mensajes de los commits

  • Clarifica el uso demake build -j (i.e.: NO usar)
  • Pineasphinx ~= 8.0.0. En 8.1 agregaron los roles como built-in.
  • Remueve un par de settings en nuestroconf.py para reducir la brecha entre el nuestro y el de cpython

During the migration to 3.13 it was suggested to use `make build -j` toautomatically speed up the building process of the documentation to useall available cores. This is red herring in two different ways: * `make`'s `-j` flag can be used to parallelise the processing of   `make` target dependencies instead of magically apply parallelisation   to the underlying commands. In our case the `make build` command has   a sequential sequence of dependencies (venv -> setup -> do_build) so   no actual parallelisation is achieved when passing `-j`.   `sphinx-build` can be parallelised by giving *it* a `-j` flag,   which we already do (`-j auto`). In other words, there's nothing to   do on our side to speed things up even further. What we *do* have   though is a `make` `SPHINX_JOBS` variable, which acts as the argument   to `sphinx-build -j`. Using this users can reduce the number of CPUs   they want to use for the build process. * Secondly, an empty `make -j` option (i.e., without a number   afterwards), contrary to popular belief, runs as many recipes in   parallel as possible [1], *with no regards to the number of available   cores*. In most scenarios this is fine because the number of   dependencies for a given target isn't that great, or because the   target instructions are not that heavy, but it can generate   difficult-to-understand problems on occasion. For example, if you are   building a shared library that consists on 250 files of heavy C++,   you'll end up spawning 250 C++ compilers at the same time, which   surely will consume all the memory of your computer, causing them to   be OOM-killed. Bottom-line is: never use -j without a value.Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
8.1 introduces the built-in cvw/cwe roles. During the migration therequirement was bumped to 8.1 while trying to sort out a problem withthe pypi role, which turned out to be the cpython submodule not beingcommitted/pushed properly earlier, and hence the update wasn't necessary(and broke things).Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
These are already defined in cpython's, let's thus remove the amount ofoverriding we need to provide.Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
@cmaureircmaureir merged commit884379d intopython:3.13Nov 22, 2024
3 of 4 checks passed
@rtobarrtobar deleted the 3.13 branchNovember 22, 2024 10:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cmaureircmaureircmaureir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@rtobar@cmaureir

[8]ページ先頭

©2009-2025 Movatter.jp