fix find_in_po. Make it Windows compatible#2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

rtobar merged 3 commits intopython:3.12fromcacrespo:fix_find_in_po

Oct 28, 2023

Merged

fix find_in_po. Make it Windows compatible#2714

rtobar merged 3 commits intopython:3.12fromcacrespo:fix_find_in_po

Oct 28, 2023

Conversation

Copy link

Collaborator

cacrespo commentedOct 26, 2023

Use os.get_terminal_size() instead of stty size for width

Use os.get_terminal_size() instead of stty size for width

b710af2

marcorichetta reviewed

Oct 26, 2023

View reviewed changes

scripts/find_in_po.py OutdatedShow resolvedHide resolved

Update scripts/find_in_po.py

f149923

Co-authored-by: Marco Richetta <marco.richetta@mercadolibre.com>

Copy link

CollaboratorAuthor

cacrespo commentedOct 26, 2023

@marcorichetta gracias por la sugerencia. Toda la razón my friend!

marcorichetta approved these changes

Oct 27, 2023

View reviewed changes

rtobar reviewed

Oct 28, 2023

View reviewed changes

Copy link

Collaborator

rtobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Aún no entiendo por qué el except no estaba funcionando cuando debiera haber atrapado el error de que no hacía un programa stty en Windows, pero al menos esto abrió una buena discusión. Acá dejo mi comentario, creo que este código se puede simplificar aún más