Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Completing the built-in functions file (library/functions.po)#254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
humitos merged 41 commits into3.8fromclaudia_finish_functions
May 22, 2020

Conversation

clacri
Copy link
Contributor

@clacriclacri commentedMay 13, 2020•
edited by humitos
Loading

I'm aiming to finish this as soon as possible but will split in different PR. This one can be reviewed.

First part of issue#61

Closes#61

@clacriclacri marked this pull request as draftMay 13, 2020 18:16
@clacriclacri marked this pull request as ready for reviewMay 17, 2020 21:46
@hectorcanto
Copy link
Contributor

Lo revisaré en breve

@hectorcanto
Copy link
Contributor

me encanta invocable como substituto de callable, ¿lo has puesto en la memoria?

@hectorcanto
Copy link
Contributor

Revisión de lo que está hasta ahora,@clacri . Buen trabajo!!

clacriand others added5 commitsMay 21, 2020 19:38
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
Co-authored-by: Héctor Canto <hectorcanto@gmail.com>
@clacri
Copy link
ContributorAuthor

Revisión de lo que está hasta ahora,@clacri . Buen trabajo!!

muchas gracias hector, metere tus sugerencias y revisare las propuestas, y cuando esté eso y arregle el build ya lo dejo que hagan un primer merge y abro otra PR el finde para la otra mitad

clacriand others added2 commitsMay 21, 2020 20:55
@clacri
Copy link
ContributorAuthor

me encanta invocable como substituto de callable, ¿lo has puesto en la memoria?

ya estaba puesto por el glosario pero he añadido que lo he usado así también en functions.po

@clacri
Copy link
ContributorAuthor

soy incapaz de encontrar lo que está causando el error en el build :(

clacriand others added3 commitsMay 22, 2020 14:19
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
If you look closer, the ones that I'm deleting are not related to any linenumber in the .rst file. That's why Sphinx was failing on these.
Note that this adds some paragraphs that I removed in the previous commit.
@humitos
Copy link
Collaborator

I'm going to merge this PR since it's already reviewed. I was able to fix the issue with broken link. I'm not super happy with the solution, since I'm not 100% sure to understand it, because I removed some paragraphs that I thought it were wrong and they were re-added automatically when I upgraded the translation from the sources.

Anyways, good news is that we can continue working now!

@humitoshumitos merged commitcaeeb79 into3.8May 22, 2020
@humitoshumitos deleted the claudia_finish_functions branchMay 22, 2020 15:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cmaureircmaureircmaureir left review comments

@hectorcantohectorcantohectorcanto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translatinglibrary/functions.po
4 participants
@clacri@hectorcanto@humitos@cmaureir
[8]ページ先頭
©2009-2025 Movatter.jp